subprocess.run(cmd, input='text') should pass universal_newlines=True to Popen

[4kir4]

BPO	27273
Nosy	@gpshead, @4kir4, @ukarroum
Files	text_input.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2022-01-12.20:00:21.466>
created_at = <Date 2016-06-08.23:59:23.910>
labels = ['type-feature', 'library']
title = "subprocess.run(cmd, input='text') should pass universal_newlines=True to Popen"
updated_at = <Date 2022-01-12.20:00:21.465>
user = 'https://github.com/4kir4'

bugs.python.org fields:

activity = <Date 2022-01-12.20:00:21.465>
actor = 'gregory.p.smith'
assignee = 'none'
closed = True
closed_date = <Date 2022-01-12.20:00:21.466>
closer = 'gregory.p.smith'
components = ['Library (Lib)']
creation = <Date 2016-06-08.23:59:23.910>
creator = 'akira'
dependencies = []
files = ['43314']
hgrepos = []
issue_num = 27273
keywords = ['patch']
message_count = 3.0
messages = ['267936', '410418', '410428']
nosy_count = 3.0
nosy_names = ['gregory.p.smith', 'akira', 'ukarroum']
pr_nums = []
priority = 'normal'
resolution = 'rejected'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue27273'
versions = ['Python 3.6']

[4kir4]

At the moment, subprocess.run(cmd, input='text') raises TypeError.
It would be nice if universal_newlines=isinstance(input, str) if *input* is set.

I've attached a corresponding patch with the necessary changes to the docs, tests and the subprocess.run() code.

[ukarroum]

As of 3.7, the subprocess.run has a new parameter "text".

IMO it's safer to explicitly set the "text" value instead of inferring it from the "input" type.

[gpshead]

agreed.