set_bitfields() unused in _ctypes_test

[vadmium]

BPO	27679
Nosy	@vstinner, @vadmium, @nanjekyejoannah, @shihai1991
PRs	bpo-27679: Remove set_bitfields() #14648

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-07-09.18:02:05.101>
created_at = <Date 2016-08-04.08:32:36.307>
labels = ['extension-modules', 'ctypes', 'tests', '3.9']
title = 'set_bitfields() unused in _ctypes_test'
updated_at = <Date 2019-07-09.18:02:05.090>
user = 'https://github.com/vadmium'

bugs.python.org fields:

activity = <Date 2019-07-09.18:02:05.090>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2019-07-09.18:02:05.101>
closer = 'vstinner'
components = ['Extension Modules', 'Tests', 'ctypes']
creation = <Date 2016-08-04.08:32:36.307>
creator = 'martin.panter'
dependencies = []
files = []
hgrepos = []
issue_num = 27679
keywords = ['patch']
message_count = 3.0
messages = ['271956', '347569', '347570']
nosy_count = 4.0
nosy_names = ['vstinner', 'martin.panter', 'nanjekyejoannah', 'shihai1991']
pr_nums = ['14648']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue27679'
versions = ['Python 3.9']

[vadmium]

Modules/_ctypes/_ctypes_test.c defines a structure called BITS and exports two C functions set_bitfields() and unpack_bitfields() that operate on it. However only unpack_bitfields() seems to have been used, in Lib/ctypes/test/test_bitfields.py. Either there is scope for enhancing the tests, or maybe there is no point and the function can be removed.

[vstinner]

New changeset 3a3db97 by Victor Stinner (Hai Shi) in branch 'master':
bpo-27679: Remove set_bitfields() from _ctypes_test (GH-14648)
3a3db97

[vstinner]

I don't feel the need to backport the change to Python 3.8 and older. Having an unused in a test module (_ctypes_test) doesn't hurt. I close the issue.

Thanks Martin Panter for the report, thanks Hai Shi for the fix ;-)