Simplify test_winsound

[zware]

BPO	27748
Nosy	@pfmoore, @tjguk, @zware, @zooba
Files	simplify_test_winsound.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zware'
closed_at = <Date 2016-09-05.21:15:39.355>
created_at = <Date 2016-08-12.17:12:35.966>
labels = ['type-bug', 'tests', 'OS-windows']
title = 'Simplify test_winsound'
updated_at = <Date 2016-09-05.23:10:53.865>
user = 'https://github.com/zware'

bugs.python.org fields:

activity = <Date 2016-09-05.23:10:53.865>
actor = 'python-dev'
assignee = 'zach.ware'
closed = True
closed_date = <Date 2016-09-05.21:15:39.355>
closer = 'python-dev'
components = ['Tests', 'Windows']
creation = <Date 2016-08-12.17:12:35.966>
creator = 'zach.ware'
dependencies = []
files = ['44089']
hgrepos = []
issue_num = 27748
keywords = ['patch']
message_count = 4.0
messages = ['272546', '274433', '274450', '274459']
nosy_count = 5.0
nosy_names = ['paul.moore', 'tim.golden', 'python-dev', 'zach.ware', 'steve.dower']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue27748'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6']

[zware]

test_winsound is rather annoying. It currently attempts to determine whether a sound card is present, and whether particular system sounds are available. These checks are fragile at best, and I routinely see failures that shouldn't be. In particular, if I have an open RDP session to my ware-win81-release buildbot, test_winsound fails because it thinks the sounds should fail to play, but instead they succeed.

Rather than attempt to make the checks more robust, I suggest that we instead rip out the checks and simply ensure that each call that might succeed either returns normally or raises RuntimeError. After all, we can't actually test whether a sound really played or not.

[python-dev]

New changeset 4c91651912d1 by Zachary Ware in branch '2.7':
Issue bpo-27748: Simplify test_winsound.
https://hg.python.org/cpython/rev/4c91651912d1

New changeset 82467d0dbaea by Zachary Ware in branch '3.5':
Issue bpo-27748: Simplify test_winsound.
https://hg.python.org/cpython/rev/82467d0dbaea

New changeset 27cbdd8cf67f by Zachary Ware in branch 'default':
Closes bpo-27748: Merge with 3.5
https://hg.python.org/cpython/rev/27cbdd8cf67f

[python-dev]

New changeset 6137d0ed0a15 by Zachary Ware in branch '2.7':
Issue bpo-27748: strengthen test_alias_nofallback
https://hg.python.org/cpython/rev/6137d0ed0a15

New changeset f845e24d794e by Zachary Ware in branch '3.5':
Issue bpo-27748: strengthen test_alias_nofallback
https://hg.python.org/cpython/rev/f845e24d794e

New changeset 5e8b865ffedd by Zachary Ware in branch 'default':
Issue bpo-27748: Merge with 3.5
https://hg.python.org/cpython/rev/5e8b865ffedd

[python-dev]

New changeset fb74947843eb by Zachary Ware in branch '2.7':
Issue bpo-27748: Backed out changeset 6137d0ed0a15
https://hg.python.org/cpython/rev/fb74947843eb

New changeset e85ce70b73b3 by Zachary Ware in branch '3.5':
Issue bpo-27748: Backed out changeset f845e24d794e
https://hg.python.org/cpython/rev/e85ce70b73b3

New changeset 29300ed6dffe by Zachary Ware in branch 'default':
Issue bpo-27748: Merge with 3.5
https://hg.python.org/cpython/rev/29300ed6dffe