Clang warnings: code will never be executed

[vstinner]

BPO	28152
Nosy	@vstinner, @benjaminp, @serhiy-storchaka

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-12-05.17:05:19.509>
created_at = <Date 2016-09-14.13:45:33.199>
labels = ['3.7']
title = 'Clang warnings: code will never be executed'
updated_at = <Date 2016-12-05.17:12:20.164>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2016-12-05.17:12:20.164>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2016-12-05.17:05:19.509>
closer = 'vstinner'
components = []
creation = <Date 2016-09-14.13:45:33.199>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 28152
keywords = []
message_count = 5.0
messages = ['276448', '282435', '282436', '282437', '282439']
nosy_count = 4.0
nosy_names = ['vstinner', 'benjamin.peterson', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue28152'
versions = ['Python 3.7']

[vstinner]

The issue bpo-23545 enabled extra warnings on GCC. Clang on FreeBSD now complains about unreachable (dead) code:

http://buildbot.python.org/all/builders/AMD64%20FreeBSD%20CURRENT%20Non-Debug%203.x/builds/281/steps/compile/logs/warnings%20%2814%29

Python/ast.c:3133:5: warning: code will never be executed [-Wunreachable-code]
Modules/posixmodule.c:10256:5: warning: code will never be executed [-Wunreachable-code]
Modules/zipimport.c:1004:22: warning: code will never be executed [-Wunreachable-code]
Modules/faulthandler.c:988:5: warning: code will never be executed [-Wunreachable-code]

See also my change ea00c88f7f42 which fixed a similar issue in Parser/grammar.c.

See also the issue bpo-14656.

[python-dev]

New changeset b3f1210d098d by Victor Stinner in branch 'default':
Issue bpo-28152: Fix -Wunreachable-code warnings on Clang
https://hg.python.org/cpython/rev/b3f1210d098d

New changeset 390fbb9c5e59 by Victor Stinner in branch 'default':
Issue bpo-28152: Fix -Wunreachable-code warning on clang
https://hg.python.org/cpython/rev/390fbb9c5e59

[python-dev]

New changeset 7c7055305f69 by Victor Stinner in branch 'default':
Issue bpo-28152: Fix -Wunreachable-code warning on clang
https://hg.python.org/cpython/rev/7c7055305f69

[vstinner]

My commits fixed all warnings using clang 3.8.0 on Fedora 25.

[serhiy-storchaka]

Thanks Victor.