Logger methods never use kwargs

[jb098]

BPO	28443
Nosy	@vsajip, @matrixise, @jb098
Files	loggingkwargs.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-12-31.11:48:59.838>
created_at = <Date 2016-10-14.15:09:14.081>
labels = ['3.7', 'type-feature', 'library']
title = 'Logger methods never use kwargs'
updated_at = <Date 2016-12-31.11:48:59.837>
user = 'https://github.com/jb098'

bugs.python.org fields:

activity = <Date 2016-12-31.11:48:59.837>
actor = 'vinay.sajip'
assignee = 'none'
closed = True
closed_date = <Date 2016-12-31.11:48:59.838>
closer = 'vinay.sajip'
components = ['Library (Lib)']
creation = <Date 2016-10-14.15:09:14.081>
creator = 'jb098'
dependencies = []
files = ['45092']
hgrepos = []
issue_num = 28443
keywords = ['patch']
message_count = 4.0
messages = ['278653', '278658', '278670', '284386']
nosy_count = 3.0
nosy_names = ['vinay.sajip', 'matrixise', 'jb098']
pr_nums = []
priority = 'normal'
resolution = 'wont fix'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue28443'
versions = ['Python 3.7']

[jb098]

The methods on the Logger class e.g. logger.debug all accept **kwargs, these are passed to the _log method but they are never used.

If _log attached them as an attribute to the LogRecord object, it would allow for creation of more powerful Filter objects to be created.

You would then be able to filter log lines based on arbitrary keyword arguments.

I've attached a patch along with tests that I think would be a sensible addition and I think that this shouldn't impact existing users of the module.

[vsajip]

Those signatures have **kwargs for potential extension of the logging API itself (without extending the existing argument list), not for passing arguments to filters.

You can already filter completely flexibly by passing additional values in the "extra" parameter, which writes those to the LogRecord. This can be inspected by filters in the same way as you propose, so there seems no reason to provide another way of doing this.

N.B. Removed larry from the nosy list, as he was apparently added by accident when the "Argument Clinic" component was selected in error.

[matrixise]

In your patch, there is an assignation to self.kwargs = kwargs but you don't use it into your code. Maybe with inheritance ?

[vsajip]

I'll close this - as indicated in my comment, there's no need for this enhancement, as the already available "extra" parameter performs the same function.