Unifying Long Integers and Integers in 2.7

[serhiy-storchaka]

BPO	28998
Nosy	@benjaminp, @serhiy-storchaka
Files	py2_int_long.diff py2_int_long_2.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2016-12-27.13:10:23.163>
created_at = <Date 2016-12-17.09:37:38.883>
labels = ['extension-modules', 'library']
title = 'Unifying Long Integers and Integers in 2.7'
updated_at = <Date 2016-12-27.13:10:23.162>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2016-12-27.13:10:23.162>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2016-12-27.13:10:23.163>
closer = 'serhiy.storchaka'
components = ['Extension Modules', 'Library (Lib)']
creation = <Date 2016-12-17.09:37:38.883>
creator = 'serhiy.storchaka'
dependencies = []
files = ['45935', '46028']
hgrepos = []
issue_num = 28998
keywords = ['patch']
message_count = 3.0
messages = ['283479', '283990', '284093']
nosy_count = 3.0
nosy_names = ['benjamin.peterson', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue28998'
versions = ['Python 2.7']

[serhiy-storchaka]

Since implementing PEP-237 (Unifying Long Integers and Integers) in Python 2.4 int and long instances became interchangeable. Virtually any function that needs an integer, accepts both int and long. But there are few places where only int is accepted. Since it is easy unintentionally convert int to long (add and subtract large int, or add 0L), this can lead to subtle errors in rare circumstances.

Proposed patch makes few places that accepted only int accepting long too. This mainly is changing isinstance(x, int) to isinstance(x, (int, long)).

[serhiy-storchaka]

Added checks for errors in C code (they are needed even without supporting Python longs, PyInt_AsLong() can fail with Python ints) and a fast path for Python longs in PyInt_AsLong() (avoid creating temporary Python int).

[python-dev]

New changeset ffcb321ba9c0 by Serhiy Storchaka in branch '2.7':
Issue bpo-28998: More APIs now support longs as well as ints.
https://hg.python.org/cpython/rev/ffcb321ba9c0