[HPUX] compilation error in pytime.c with cc compiler

[haney]

BPO	30183
Nosy	@vstinner, @haney, @datalogics-robb, @michael-o
PRs	bpo-30183: Fixes HP-UX cc compilation error in pytime.c #1351 bpo-30183: Modify configure to link with the compiler driver under HP-UX #2519
Files	tests.out

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-07-03.11:18:52.489>
created_at = <Date 2017-04-27.04:24:50.087>
labels = ['build', '3.7']
title = '[HPUX] compilation error in pytime.c with cc compiler'
updated_at = <Date 2018-07-03.11:18:52.487>
user = 'https://github.com/haney'

bugs.python.org fields:

activity = <Date 2018-07-03.11:18:52.487>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2018-07-03.11:18:52.489>
closer = 'vstinner'
components = ['Build']
creation = <Date 2017-04-27.04:24:50.087>
creator = 'haney'
dependencies = []
files = ['46995']
hgrepos = []
issue_num = 30183
keywords = []
message_count = 15.0
messages = ['292397', '292423', '292438', '292439', '296553', '296572', '297406', '297409', '297410', '297427', '297589', '297893', '298000', '320959', '320961']
nosy_count = 4.0
nosy_names = ['vstinner', 'haney', 'Robert Boehne', 'michael-o']
pr_nums = ['1351', '2519']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue30183'
versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']

[haney]

When compiling on HP-UX with the native cc compiler, the following compilation error occurs in pytime.c

    cc -Ae -c  -O  -O     -I. -I./Include    -DPy_BUILD_CORE -o [Python/pytime.o](https://github.com/python/cpython/blob/main/Python/pytime.o) [Python/pytime.c](https://github.com/python/cpython/blob/main/Python/pytime.c)

"Python/pytime.c", line 723: error bpo-2020: identifier "CLOCK_MONOTONIC" is
undefined
const clockid_t clk_id = CLOCK_MONOTONIC;
^

1 error detected in the compilation of "Python/pytime.c".
*** Error exit code 2

Stop.

HP-UX does not support the CLOCK_MONOTONIC state.

[vstinner]

HP-UX does not support the CLOCK_MONOTONIC state.

I'm sorry but CPython requires a monotonic clock since CPython 3.5.

According to https://bugreports.qt.io/browse/QTBUG-22301 HP-UX < 11.3 and Solaris 9 don't support monotonic clock.

It seems like gethrtime() is the right function to be used on HP-UX.
https://docstore.mik.ua/manuals/hp-ux/en/B2355-60130/gethrtime.3C.html

"gethrtime() is measured from an unspecified starting point and is not subject to time server and administrator changes"
src: http://nadeausoftware.com/articles/2012/04/c_c_tip_how_measure_elapsed_real_time_benchmarking#gethrtimenbsp

[haney]

It seems like gethrtime() is the right function to be used on HP-UX.
https://docstore.mik.ua/manuals/hp-ux/en/B2355-60130/gethrtime.3C.html

Thanks, I'll work on getting a patch that leverages gethrtime() tested and submitted for review.

[vstinner]

I'm quite sure that once I wrote a patch using gethrtime() for Solaris, but then I saw that it's the same clock than clock_gettime(CLOCK_MONOTONIC), so I removed gethrtime() to simplify the code.

See also my PEP-418, which mentions gethrtime() by the way:
https://www.python.org/dev/peps/pep-0418/#solaris-gethrtime

[haney]

I submitted a pull request for a possible fix for this issue but haven't received any feedback yet. Is there any additional information needed from me?

[vstinner]

New changeset c90e960 by Victor Stinner (haney) in branch 'master':
bpo-30183: Fixes HP-UX cc compilation error in pytime.c (bpo-1351)
c90e960

[datalogics-robb]

I'd love to have this fix backported to 3.5 and 3.6. It seems trivial to do, and I'd be happy to do it myself.

[vstinner]

I'd love to have this fix backported to 3.5 and 3.6. It seems trivial to do, and I'd be happy to do it myself.

Go ahead :-)

[vstinner]

Can someone please give the list of failing tests of the Python master branch on HP-UX?

[datalogics-robb]

I am having trouble getting things build still. The problem is that the build is using a naked "ld" to link, and it is picking 32-bit mode by default in my 64-bit acc build. (Itanium)

IMO the problem is configure.ac:2467 which should look more like the gcc section. I can produce a patch, and perhaps you can walk me though the submission process.

[vstinner]

@david Haney: Can you please give the list of tests which fail on HP-UX? I would like to have an idea of the status of the HP-UX support.

[haney]

I've attached the test output summary from a recent build.