Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove own implementation for thread-local storage #75015

Closed
ma8ma mannequin opened this issue Jul 3, 2017 · 5 comments
Closed

Remove own implementation for thread-local storage #75015

ma8ma mannequin opened this issue Jul 3, 2017 · 5 comments
Labels
3.7 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@ma8ma
Copy link
Mannequin

ma8ma mannequin commented Jul 3, 2017

BPO 30832
Nosy @vstinner, @ma8ma
PRs
  • bpo-30832: Remove own implementation for thread-local storage #2537
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-07-03.14:00:29.256>
    created_at = <Date 2017-07-03.08:23:53.413>
    labels = ['interpreter-core', 'type-feature', '3.7']
    title = 'Remove own implementation for thread-local storage'
    updated_at = <Date 2017-07-05.13:44:56.600>
    user = 'https://github.com/ma8ma'

    bugs.python.org fields:

    activity = <Date 2017-07-05.13:44:56.600>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-07-03.14:00:29.256>
    closer = 'vstinner'
    components = ['Interpreter Core']
    creation = <Date 2017-07-03.08:23:53.413>
    creator = 'masamoto'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 30832
    keywords = []
    message_count = 5.0
    messages = ['297543', '297547', '297572', '297588', '297749']
    nosy_count = 2.0
    nosy_names = ['vstinner', 'masamoto']
    pr_nums = ['2537']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue30832'
    versions = ['Python 3.7']

    @ma8ma
    Copy link
    Mannequin Author

    ma8ma mannequin commented Jul 3, 2017

    CPython has provided the own implementation for thread-local storage (TLS) on Python/thread.c, it's used in the case which a platform has not supplied native TLS. However, currently all supported platforms (NT and pthreads) have provided native TLS and defined the Py_HAVE_NATIVE_TLS macro with unconditional in any case.
    Therefore, I'd propose removing outdated code.

    python-dev: https://mail.python.org/pipermail/python-dev/2017-July/148534.html

    @ma8ma ma8ma mannequin added 3.7 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Jul 3, 2017
    @vstinner
    Copy link
    Member

    vstinner commented Jul 3, 2017

    This change is related to the PEP-539: the new Thread-Local Storage (TLS) API.

    @vstinner
    Copy link
    Member

    vstinner commented Jul 3, 2017

    New changeset aa0aa04 by Victor Stinner (Masayuki Yamamoto) in branch 'master':
    bpo-30832: Remove own implementation for thread-local storage (bpo-2537)
    aa0aa04

    @vstinner
    Copy link
    Member

    vstinner commented Jul 3, 2017

    Well done, I didn't see any major outdage (compilation error) on 3.x buildbots ;-)

    @vstinner vstinner closed this as completed Jul 3, 2017
    @vstinner
    Copy link
    Member

    vstinner commented Jul 5, 2017

    New changeset 8207c17 by Victor Stinner in branch 'master':
    Revert "bpo-30822: Fix testing of datetime module." (bpo-2588)
    8207c17

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant