Coverity: CID 1428443: Null pointer dereferences (NULL_RETURNS) /Python/hamt.c: 1058 in hamt_node_bitmap_without()

[vstinner]

BPO	32639
Nosy	@vstinner, @1st1

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-01-23.21:26:57.140>
created_at = <Date 2018-01-23.20:58:35.768>
labels = ['interpreter-core', 'type-bug', '3.7']
title = 'Coverity: CID 1428443: Null pointer dereferences (NULL_RETURNS) /Python/hamt.c: 1058 in hamt_node_bitmap_without()'
updated_at = <Date 2018-01-23.21:47:25.886>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2018-01-23.21:47:25.886>
actor = 'yselivanov'
assignee = 'none'
closed = True
closed_date = <Date 2018-01-23.21:26:57.140>
closer = 'yselivanov'
components = ['Interpreter Core']
creation = <Date 2018-01-23.20:58:35.768>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 32639
keywords = []
message_count = 4.0
messages = ['310522', '310524', '310526', '310527']
nosy_count = 2.0
nosy_names = ['vstinner', 'yselivanov']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue32639'
versions = ['Python 3.7']

[vstinner]

Coverity found a bug in hamt.c:

** CID 1428443: Null pointer dereferences (NULL_RETURNS)
/Python/hamt.c: 1058 in hamt_node_bitmap_without()

________________________________________________________________________________________________________
*** CID 1428443:  Null pointer dereferences  (NULL_RETURNS)
/Python/hamt.c: 1058 in hamt_node_bitmap_without()
1052                         assert(hamt_node_collision_count(
1053                                 (PyHamtNode_Collision*)sub_node) > 1);
1054                     }
1055     #endif
1056
1057                     PyHamtNode_Bitmap *clone = hamt_node_bitmap_clone(self);
>>>     CID 1428443:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a null pointer "clone".
1058                     Py_SETREF(clone->b_array[val_idx],
1059                               (PyObject *)sub_node);  /* borrow */
1060
1061                     *new_node = (PyHamtNode *)clone;
1062                     return W_NEWNODE;
1063                 }

[1st1]

Victor, it's been already fixed/tracked here: #5286

(I also receive coverity reports :)

[vstinner]

(I also receive coverity reports :)

Oh, I didn't know. The current workflow is not ideal to avoid duplicated issues.

[1st1]

Oh, I didn't know. The current workflow is not ideal to avoid duplicated issues.

If I fix something that's been reported there I usually update the coverity issue directly. But yeah...