Fix secrets.randbelow docstring

[nixawk]

BPO	33292
Nosy	@mdickinson, @stevendaprano, @serhiy-storchaka, @nixawk
PRs	bpo-33292: Fix secrets.randbelow docstring #6497

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-04-17.10:09:21.402>
created_at = <Date 2018-04-17.03:09:36.251>
labels = ['3.8', 'library', 'invalid', 'performance']
title = 'Fix secrets.randbelow docstring'
updated_at = <Date 2018-04-18.09:47:59.981>
user = 'https://github.com/Nixawk'

bugs.python.org fields:

activity = <Date 2018-04-18.09:47:59.981>
actor = 'Nixawk'
assignee = 'none'
closed = True
closed_date = <Date 2018-04-17.10:09:21.402>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2018-04-17.03:09:36.251>
creator = 'Nixawk'
dependencies = []
files = []
hgrepos = []
issue_num = 33292
keywords = ['patch']
message_count = 7.0
messages = ['315376', '315378', '315383', '315387', '315395', '315440', '315443']
nosy_count = 4.0
nosy_names = ['mark.dickinson', 'steven.daprano', 'serhiy.storchaka', 'Nixawk']
pr_nums = ['6497']
priority = 'normal'
resolution = 'not a bug'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue33292'
versions = ['Python 3.8']

[nixawk]

• https://github.com/python/cpython/blob/master/Lib/secrets.py#L28

Please fix

"""Return a random int in the range [0, n)."""

to

"""Return a random int in the range(0, n)."""

[serhiy-storchaka]

What is wrong with the current docstring?

[nixawk]

Please use () or []

[serhiy-storchaka]

I don't think that intervals [0, n-1] or (-1, n) would look better than [0, n).

[stevendaprano]

Possibly you may not be familiar with interval notation?

https://www.mathsisfun.com/sets/intervals.html

Since this is Python and not maths, maybe we should rethink the wording.

[mdickinson]

"""Return a random integer x satisfying 0 <= x < n""" ?

[nixawk]

It looks simple and good.