[EASY] Windows: test_regrtest fails on installed Python

[vstinner]

BPO	33352
Nosy	@terryjreedy, @pfmoore, @vstinner, @tjguk, @zware, @zooba
PRs	bpo-33352: Skip test if rt.bat does not exist #6654 [3.7] bpo-33352: Skip test_regrtest test if rt.bat does not exist (GH-6654) #6656

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-04-30.20:38:53.617>
created_at = <Date 2018-04-25.13:46:37.693>
labels = ['easy', 'type-bug', '3.8', '3.7', 'tests', 'OS-windows']
title = '[EASY] Windows: test_regrtest fails on installed Python'
updated_at = <Date 2018-04-30.20:38:59.873>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2018-04-30.20:38:59.873>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2018-04-30.20:38:53.617>
closer = 'vstinner'
components = ['Tests', 'Windows']
creation = <Date 2018-04-25.13:46:37.693>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 33352
keywords = ['patch', 'easy']
message_count = 6.0
messages = ['315730', '315856', '315942', '315952', '315962', '315963']
nosy_count = 6.0
nosy_names = ['terry.reedy', 'paul.moore', 'vstinner', 'tim.golden', 'zach.ware', 'steve.dower']
pr_nums = ['6654', '6656']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33352'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

[vstinner]

Failure on Windows 10 with Python 3.7 beta 3:

======================================================================
ERROR: test_pcbuild_rt (test.test_regrtest.ProgramsTestCase)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "C:\Users\vstinner\AppData\Local\Programs\Python\Python37\lib\test\test_regrtest.py", line 602, in test_pcbuild_rt
    self.run_batch(script, *rt_args, *self.regrtest_args, *self.tests)
  File "C:\Users\vstinner\AppData\Local\Programs\Python\Python37\lib\test\test_regrtest.py", line 577, in run_batch
    proc = self.run_command(args)
  File "C:\Users\vstinner\AppData\Local\Programs\Python\Python37\lib\test\test_regrtest.py", line 475, in run_command
    **kw)
  File "C:\Users\vstinner\AppData\Local\Programs\Python\Python37\lib\subprocess.py", line 453, in run
    with Popen(*popenargs, **kwargs) as process:
  File "C:\Users\vstinner\AppData\Local\Programs\Python\Python37\lib\subprocess.py", line 756, in __init__
    restore_signals, start_new_session)
  File "C:\Users\vstinner\AppData\Local\Programs\Python\Python37\lib\subprocess.py", line 1155, in _execute_child
    startupinfo)
FileNotFoundError: [WinError 2] The system cannot find the file specified

We may just skip the test if the script is not installed.

[terryjreedy]

On my system: py -3.n -m test.test_regrtest (or test test_regrtest) fails for n in {5, 6, 7}. 2.7 runs, but there are far fewer test methods. Repository builds work fine.

[vstinner]

The fix is simple, skip the test if the script doesn't exist at:

    def test_pcbuild_rt(self):
        # PCbuild\rt.bat
        script = os.path.join(ROOT_DIR, r'PCbuild\rt.bat')

[vstinner]

New changeset c3b7a6d by Victor Stinner (Andrés Delfino) in branch 'master':
bpo-33352: Skip test_regrtest test if rt.bat does not exist (GH-6654)
c3b7a6d

[vstinner]

New changeset 8075868 by Victor Stinner (Miss Islington (bot)) in branch '3.7':
bpo-33352: Skip test_regrtest test if rt.bat does not exist (GH-6654) (bpo-6656)
8075868

[vstinner]

I'm not sure that Python 3.6. In case of doubt, I prefer to skip it.

The bug has been fixed in Python 3.7 and master. Thanks Andrés Delfino for your nice contribution!