test_from_import_missing_attr_has_name_and_so_path fails when select is a builtin instead of an extension

[doko42]

BPO	33465
Nosy	@warsaw, @brettcannon, @doko42, @ncoghlan, @ericsnowcurrently, @serhiy-storchaka
PRs	bpo-33465: Use an unlikely to be built-in C extension in a test #6797 [3.7] bpo-33465: Use an unlikely to be built-in C extension in a test (GH-6797) #6869

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/warsaw'
closed_at = <Date 2018-05-15.21:24:46.281>
created_at = <Date 2018-05-11.16:07:04.328>
labels = ['3.7', '3.8', 'type-bug', 'tests']
title = 'test_from_import_missing_attr_has_name_and_so_path fails when select is a builtin instead of an extension'
updated_at = <Date 2018-05-15.21:24:46.280>
user = 'https://github.com/doko42'

bugs.python.org fields:

activity = <Date 2018-05-15.21:24:46.280>
actor = 'barry'
assignee = 'barry'
closed = True
closed_date = <Date 2018-05-15.21:24:46.281>
closer = 'barry'
components = ['Tests']
creation = <Date 2018-05-11.16:07:04.328>
creator = 'doko'
dependencies = []
files = []
hgrepos = []
issue_num = 33465
keywords = ['patch']
message_count = 6.0
messages = ['316403', '316509', '316514', '316560', '316691', '316731']
nosy_count = 6.0
nosy_names = ['barry', 'brett.cannon', 'doko', 'ncoghlan', 'eric.snow', 'serhiy.storchaka']
pr_nums = ['6797', '6869']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33465'
versions = ['Python 3.7', 'Python 3.8']

[doko42]

======================================================================
ERROR: test_from_import_missing_attr_has_name_and_so_path (test.test_import.ImportTests)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/usr/lib/python3.7/test/test_import/__init__.py", line 98, in test_from_import_missing_attr_has_name_and_so_path
    self.assertEqual(cm.exception.path, select.__file__)
AttributeError: module 'select' has no attribute '__file__'

---

Ran 75 tests in 0.618s

FAILED (errors=1, skipped=1)
test test_import failed

[warsaw]

It seems pretty easy to use an extension module that's less likely to be built-in. What about binascii?

[warsaw]

binascii gets built-in too, so it seems like _hashlib is a good choice.

[serhiy-storchaka]

I think that in any case this test should be marked as CPython-only.

[warsaw]

New changeset 8709b23 by Barry Warsaw in branch 'master':
bpo-33465: Use an unlikely to be built-in C extension in a test (bpo-6797)
8709b23

[warsaw]

New changeset 2cdb70a by Barry Warsaw (Miss Islington (bot)) in branch '3.7':
bpo-33465: Use an unlikely to be built-in C extension in a test (GH-6797) (bpo-6869)
2cdb70a