dataclasses.make_dataclass does not validate fields for being valid identifiers

[ericvsmith]

BPO	33536
Nosy	@ericvsmith, @ned-deily, @miss-islington
PRs	bpo-33536: Validate make_dataclass() field names. #6906 [3.7] bpo-33536: Validate make_dataclass() field names. (GH-6906) #6908

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ericvsmith'
closed_at = <Date 2018-05-16.18:00:50.608>
created_at = <Date 2018-05-16.12:27:58.572>
labels = ['3.8', 'type-bug', '3.7']
title = 'dataclasses.make_dataclass does not validate fields for being valid identifiers'
updated_at = <Date 2018-05-16.18:00:50.605>
user = 'https://github.com/ericvsmith'

bugs.python.org fields:

activity = <Date 2018-05-16.18:00:50.605>
actor = 'eric.smith'
assignee = 'eric.smith'
closed = True
closed_date = <Date 2018-05-16.18:00:50.608>
closer = 'eric.smith'
components = []
creation = <Date 2018-05-16.12:27:58.572>
creator = 'eric.smith'
dependencies = []
files = []
hgrepos = []
issue_num = 33536
keywords = ['patch']
message_count = 3.0
messages = ['316803', '316819', '316836']
nosy_count = 3.0
nosy_names = ['eric.smith', 'ned.deily', 'miss-islington']
pr_nums = ['6906', '6908']
priority = None
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33536'
versions = ['Python 3.7', 'Python 3.8']

[ericvsmith]

I'm going to make this a release blocker, since it's basically a code injection vector, although I know of no way to exploit it. The fix is easy enough.

[ericvsmith]

New changeset 4e81296 by Eric V. Smith in branch 'master':
bpo-33536: Validate make_dataclass() field names. (GH-6906)
4e81296

[miss-islington]

New changeset 6409e75 by Miss Islington (bot) in branch '3.7':
bpo-33536: Validate make_dataclass() field names. (GH-6906)
6409e75