Install python-docs-theme even if SPHINXBUILD is defined

[andresdelfino]

BPO	33696
Nosy	@pfmoore, @tjguk, @zware, @zooba, @andresdelfino, @miss-islington
PRs	bpo-33696: Install python-docs-theme even if SPHINXBUILD is defined #7242 [3.7] bpo-33696: Install python-docs-theme even if SPHINXBUILD is defined (GH-7242) #7248 [3.6] bpo-33696: Install python-docs-theme even if SPHINXBUILD is defined (GH-7242) #7249

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-06-02.18:29:07.906>
created_at = <Date 2018-05-30.13:20:02.394>
labels = ['3.8', 'type-feature', '3.7', 'OS-windows']
title = 'Install python-docs-theme even if SPHINXBUILD is defined'
updated_at = <Date 2018-06-02.18:29:07.905>
user = 'https://github.com/andresdelfino'

bugs.python.org fields:

activity = <Date 2018-06-02.18:29:07.905>
actor = 'adelfino'
assignee = 'none'
closed = True
closed_date = <Date 2018-06-02.18:29:07.906>
closer = 'adelfino'
components = ['Windows']
creation = <Date 2018-05-30.13:20:02.394>
creator = 'adelfino'
dependencies = []
files = []
hgrepos = []
issue_num = 33696
keywords = ['patch']
message_count = 4.0
messages = ['318183', '318197', '318203', '318204']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'adelfino', 'miss-islington']
pr_nums = ['7242', '7248', '7249']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue33696'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

[andresdelfino]

On bug 33673, I fixed python-docs-theme only getting installed if SPHINXBUILD was not defined and Sphinx was not installed, which was an improvement, but not the correct fix for python-docs-theme installation.

Now, python-docs-theme is getting installed only if SPHINXBUILD is not defined.

The attached PR fixes this, and also removes two variable assignments that are no-ops: both variables are already defined by the user as environment variables or by the script at that point.

[zooba]

New changeset 05f1c89 by Steve Dower (Andrés Delfino) in branch 'master':
bpo-33696: Install python-docs-theme even if SPHINXBUILD is defined (GH-7242)
05f1c89

[miss-islington]

New changeset ea1982a by Miss Islington (bot) in branch '3.7':
bpo-33696: Install python-docs-theme even if SPHINXBUILD is defined (GH-7242)
ea1982a

[miss-islington]

New changeset 7301dd9 by Miss Islington (bot) in branch '3.6':
bpo-33696: Install python-docs-theme even if SPHINXBUILD is defined (GH-7242)
7301dd9