Gramatically incorrect error message for some calls with wrong number of arguments

[pppery]

BPO	34127
Nosy	@rhettinger, @terryjreedy, @pppery, @tirkarthi, @bansalanjali2512
PRs	bpo-34127: Fix grammar in error message with respect to argument count #8395

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-07-22.20:14:02.863>
created_at = <Date 2018-07-16.18:38:33.829>
labels = ['interpreter-core', 'type-feature', '3.8']
title = 'Gramatically incorrect error message for some calls with wrong number of arguments'
updated_at = <Date 2018-07-23.05:55:57.520>
user = 'https://github.com/pppery'

bugs.python.org fields:

activity = <Date 2018-07-23.05:55:57.520>
actor = 'xtreak'
assignee = 'none'
closed = True
closed_date = <Date 2018-07-22.20:14:02.863>
closer = 'rhettinger'
components = ['Interpreter Core']
creation = <Date 2018-07-16.18:38:33.829>
creator = 'ppperry'
dependencies = []
files = []
hgrepos = []
issue_num = 34127
keywords = ['patch']
message_count = 10.0
messages = ['321752', '322048', '322052', '322092', '322126', '322146', '322155', '322165', '322166', '322178']
nosy_count = 5.0
nosy_names = ['rhettinger', 'terry.reedy', 'ppperry', 'xtreak', 'bansalanjali']
pr_nums = ['8395']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue34127'
versions = ['Python 3.8']

[pppery]

`{}.get()`
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: get expected at least 1 arguments, got 0

Shouldn't that be "TypeError: get expected at least 1 argument, got 0" instead?

[terryjreedy]

Yes. 0 things, (1/2 thing), 1 thing, (3/2 things), 2... things is the bugaboo of formatting sentences with a number field. Raymond, will we accept a patch for this?

[pppery]

Another test case:

> classmethod()

Traceback (most recent call last):
  File "<pyshell#25>", line 2, in check
TypeError: classmethod expected 1 arguments, got 0

[bansalanjali2512]

Is this still active? I want to fix the patch.

[rhettinger]

Raymond, will we accept a patch for this?

If the patch is simple and minimal, then this seems like a minor but nice little improvement.

[tirkarthi]

I have added a simple patch based on the changes by https://bugs.python.org/issue29951. The C code related error messages doesn't seem to have been covered by tests and I have added some tests. I have limited knowledge of C and this is my first C patch so code comments if any will be helpful.

Thanks

[terryjreedy]

We don't normally backport an exception message change unless its content, as opposed to style, is erroneous.

[rhettinger]

New changeset 1426daa by Raymond Hettinger (Xtreak) in branch 'master':
bpo-34127: Fix grammar in error message with respect to argument count (GH-8395)
1426daa

[rhettinger]

Nice work. Thanks for the patch.