3.6 ZipFile fails with Path

[mkleehammer]

BPO	34202
Nosy	@mkleehammer, @berkerpeksag, @bbayles

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-07-24.03:14:35.817>
created_at = <Date 2018-07-23.23:17:13.726>
labels = ['type-bug', 'library']
title = '3.6 ZipFile fails with Path'
updated_at = <Date 2018-07-24.03:14:35.798>
user = 'https://github.com/mkleehammer'

bugs.python.org fields:

activity = <Date 2018-07-24.03:14:35.798>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2018-07-24.03:14:35.817>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2018-07-23.23:17:13.726>
creator = 'mkleehammer'
dependencies = []
files = []
hgrepos = []
issue_num = 34202
keywords = []
message_count = 2.0
messages = ['322272', '322275']
nosy_count = 3.0
nosy_names = ['mkleehammer', 'berker.peksag', 'bbayles']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue34202'
versions = ['Python 3.6']

[mkleehammer]

ZipFile is documented to accept "path-like" objects but is failing when I try to create one. I've distilled it down to this small test:

    import zipfile
    from pathlib import Path

    path = Path('test.zip')
    zf = zipfile.ZipFile(path, 'w')
    zf.writestr('test.txt', 'Hello, Sailor!')
    zf.close()

On macOS I'm getting this error:

Traceback (most recent call last):
  File "test.py", line 7, in <module>
    zf.writestr('test.txt', 'Hello, Sailor!')
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/zipfile.py", line 1644, in writestr
    with self.open(zinfo, mode='w') as dest:
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/zipfile.py", line 1348, in open
    return self._open_to_write(zinfo, force_zip64=force_zip64)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/zipfile.py", line 1461, in _open_to_write
    self.fp.write(zinfo.FileHeader(zip64))
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/zipfile.py", line 721, in write
    n = self.fp.write(data)
AttributeError: 'PosixPath' object has no attribute 'write'

Using str(path) works fine.

[berkerpeksag]

Thanks for the report! Support for path-like objects was added in 3.6.2. I think you either have 3.6.0 or 3.6.1 installed on your system. Please upgrade it to the latest bugfix release.

With 3.6.6, I got the following results:

>> import zipfile
>> from pathlib import Path
>> path = Path('spam.zip')
>> zf = zipfile.ZipFile(path, 'w')
>> zf.writestr('test.txt', 'Hello, Sailor!')
>> zf.close()

$ ./python -m zipfile -l spam.zip 
File Name                                             Modified             Size
test.txt                                       2018-07-24 06:10:52           14