Correctly detect installed SDK versions

[jkloth]

BPO	35433
Nosy	@pfmoore, @db3l, @vstinner, @tjguk, @jkloth, @zware, @zooba, @pablogsal, @miss-islington
PRs	bpo-35433: Properly detect installed SDK versions #11009 [3.7] bpo-35433: Properly detect installed SDK versions (GH-11009) #11058 [3.6] bpo-35433: Properly detect installed SDK versions (GH-11009) #11059 [3.6] bpo-35433: Properly detect installed SDK versions (GH-11009) #11060
Files	msbuild-win10-bad.log: Failing build log msbuild-win10-good.log: Working build log

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = <Date 2018-12-11.16:06:19.104>
created_at = <Date 2018-12-07.01:03:10.727>
labels = ['3.8', 'build', '3.7', 'OS-windows']
title = 'Correctly detect installed SDK versions'
updated_at = <Date 2018-12-11.16:06:19.103>
user = 'https://github.com/jkloth'

bugs.python.org fields:

activity = <Date 2018-12-11.16:06:19.103>
actor = 'jkloth'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2018-12-11.16:06:19.104>
closer = 'jkloth'
components = ['Build', 'Windows']
creation = <Date 2018-12-07.01:03:10.727>
creator = 'jkloth'
dependencies = []
files = ['47985', '47986']
hgrepos = []
issue_num = 35433
keywords = ['patch']
message_count = 37.0
messages = ['331258', '331262', '331263', '331303', '331315', '331320', '331324', '331329', '331388', '331389', '331437', '331462', '331463', '331466', '331467', '331471', '331513', '331533', '331541', '331544', '331545', '331546', '331547', '331548', '331551', '331552', '331554', '331555', '331556', '331557', '331558', '331559', '331561', '331562', '331563', '331611', '331635']
nosy_count = 10.0
nosy_names = ['paul.moore', 'db3l', 'vstinner', 'tim.golden', 'jkloth', 'jeremy.kloth', 'zach.ware', 'steve.dower', 'pablogsal', 'miss-islington']
pr_nums = ['11009', '11058', '11059', '11060']
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue35433'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

[jkloth]

In the process of eliminating compiler warnings on my buildbot, I needed to update VS2015 to the latest toolset (VS2015 Update 3). This in turn now causes an error due about not having the required version of Windows SDK installed.

It seems that the detection logic for that uses a hard-coded list which may not be up-to-date (and possibly incorrect for some installs). Referenced PR fixes this.

[jkloth]

Also, my buildbot *should* fail until this change is merged.

[zooba]

Looks good to me. I can't apply tags from my phone, apparently, so someone else will have to merge and mark the backport versions.

[vstinner]

Is this issue related to bpo-34977: Add Windows App Store package?

[zooba]

No, it just automates something that's been manual for a while. Installing VS 2017 on build bots is still a manual process ;)

[jkloth]

Sorry Victor, I should have added more context when I nosy'ed you to this issue.

Since you seem to be the "buildbot keeper" as of late, I wanted to give you a pointer to the reason for my failing buildbot. Which, as I surmised, is failing compile due to the missing SDK error that is fixed by this PR ;)

[vstinner]

After I reverted bpo-34977 change, most Windows buildbots are back to green.

In the process of eliminating compiler warnings on my buildbot, I needed to update VS2015 to the latest toolset (VS2015 Update 3). This in turn now causes an error due about not having the required version of Windows SDK installed.

Is it a warning or an error? What is the warning/error message? What is your buildbot?

Right now, it seems like only "AMD64 Windows7 SP1 3.x" is still red:

"2>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Platforms\x64\PlatformToolsets\v140\Toolset.targets(36,5): error MSB8036: The Windows SDK version 10.0.17134.0 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution". [C:\buildbot.python.org\3.x.kloth-win64\build\PCbuild\pythoncore.vcxproj]"

https://buildbot.python.org/all/#/builders/40/builds/1322

Are you talking about this error?

[jeremykloth]

Is it a warning or an error? What is the warning/error message? What is your buildbot?

It is a compiler error as you point out below (with message). By buildbot is:

https://buildbot.python.org/all/#/workers/12

Right now, it seems like only "AMD64 Windows7 SP1 3.x" is still red:

"2>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Platforms\x64\PlatformToolsets\v140\Toolset.targets(36,5): error MSB8036: The Windows SDK version 10.0.17134.0 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution". [C:\buildbot.python.org\3.x.kloth-win64\build\PCbuild\pythoncore.vcxproj]"

https://buildbot.python.org/all/#/builders/40/builds/1322

Are you talking about this error?

All the builders on my buildbot can no longer find a matching SDK
version due to how the SDK version detection is handled. Previously,
my buildbot had VS2015.2 installed whose build tools (version 1.2)
didn't use the property DefaultWindowsSDKVersion to select the SDK
version and just defaulted to Windows 8.1 SDK. Now that I've updated
to VS2015.3 (includes build tools 1.4) it does use this property to
select the SDK version. However, I have a newer SDK installed than is
listed in the hard-coded list so it defaults to highest one in the
list causing the missing SDK error.

This PR changes the detection logic to simply accept what SDK the user
has installed as long as it is newer (or the same) as the minimum
allowed version.

For those versed in MSBuild, this should be fairly self-evident, but
hopefully this helps those who are not :)

[jkloth]

Not to be impatient or anything, but this change is keeping my buildbot from being useful. Would it be possible for someone to merge as it has already been approved (msg331263).

[zooba]

Did you see my comment about converting the version numbers to System.Version before comparing? (I didn't know it could be done the first time I looked :) )

[jkloth]

Sorry for the delay, but I wanted to get an environment that still had an older VS2015 install to test against. VS2015 prior to Update 3 use a different heuristic to determine the SDK version for building.

I've made the following changes:

• version checking uses System.Version,
• WindowsTargetPlatformVersion is set to the detected Win10 SDK (this is the offical setting anyway, but required for VS2015 prior to Update 3)
• added display of the detected SDK to ShowVersionInfo target (build.bat -V)