"make coverage" should not leak coverage compiler flags to third party C extensions

[vstinner]

BPO	35501
Nosy	@vstinner

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-02-10.23:57:24.842>
created_at = <Date 2018-12-14.18:47:02.318>
labels = ['build', '3.8']
title = '"make coverage" should not leak coverage compiler flags to third party C extensions'
updated_at = <Date 2020-02-10.23:57:24.841>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2020-02-10.23:57:24.841>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2020-02-10.23:57:24.842>
closer = 'vstinner'
components = ['Build']
creation = <Date 2018-12-14.18:47:02.318>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 35501
keywords = []
message_count = 2.0
messages = ['331850', '361757']
nosy_count = 1.0
nosy_names = ['vstinner']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue35501'
versions = ['Python 3.8']

[vstinner]

"make coverage" modifies CFLAGS and LIBS, Makefile.pre.in:

coverage:
@echo "Building with support for coverage checking:"
$(MAKE) clean profile-removal
$(MAKE) @DEF_MAKE_RULE@ CFLAGS="$(CFLAGS) -O0 -pg -fprofile-arcs -ftest-coverage" LIBS="$(LIBS) -lgcov"

CFLAGS_NODIST should be used instead here. I'm not sure about LIBS: do we need LIBS_NODIST, as we have CFLAGS_NODIST? LIBS_NODIST would be used for Python and C extensions of the stdlib, but not for third-party C extensions: not used by distutils.

See also bpo-35257: "Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST".

[vstinner]

It's unclear to me if it's a real issue or not. Moreover, I'm not comfortable to change the Makefile. So I just close the issue.