test_named_expressions raises SyntaxWarning

[tirkarthi]

BPO	35861
Nosy	@serhiy-storchaka, @emilyemorehouse, @tirkarthi
PRs	bpo-35861: test_named_expressions raises SyntaxWarning #11722 bpo-35861: test_named_expressions raises SyntaxWarning #11722 bpo-35861: test_named_expressions raises SyntaxWarning #11722

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/tirkarthi'
closed_at = <Date 2019-02-01.21:54:26.373>
created_at = <Date 2019-01-30.19:05:31.930>
labels = ['easy', '3.8', 'type-bug', 'tests']
title = 'test_named_expressions raises SyntaxWarning'
updated_at = <Date 2019-02-01.21:54:26.373>
user = 'https://github.com/tirkarthi'

bugs.python.org fields:

activity = <Date 2019-02-01.21:54:26.373>
actor = 'emilyemorehouse'
assignee = 'xtreak'
closed = True
closed_date = <Date 2019-02-01.21:54:26.373>
closer = 'emilyemorehouse'
components = ['Tests']
creation = <Date 2019-01-30.19:05:31.930>
creator = 'xtreak'
dependencies = []
files = []
hgrepos = []
issue_num = 35861
keywords = ['patch', 'patch', 'patch', 'easy']
message_count = 4.0
messages = ['334587', '334599', '334604', '334715']
nosy_count = 3.0
nosy_names = ['serhiy.storchaka', 'emilyemorehouse', 'xtreak']
pr_nums = ['11722', '11722', '11722']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue35861'
versions = ['Python 3.8']

[tirkarthi]

SyntaxWarning was recently added for comparison using "is" over literals with bpo-34850. This is raised on master for a PEP-572 related test. The warning is emitted twice which is covered with bpo-35798 and I verified the patch. The fix for this issue would be to use == as noted in the warning.

Emily, if you can confirm my report then I would like to triage this as an easy one since the fix is simple.

# SyntaxWarning on master

➜ cpython git:(master) ./python.exe Lib/test/test_named_expressions.py
Lib/test/test_named_expressions.py:168: SyntaxWarning: "is" with a literal. Did you mean "=="?
if (match := 10) is 10:
Lib/test/test_named_expressions.py:168: SyntaxWarning: "is" with a literal. Did you mean "=="?
if (match := 10) is 10:
........................................................
----------------------------------------------------------------------
Ran 56 tests in 0.010s

OK

Thanks

[emilyemorehouse]

Yes, you're exactly correct! Feel free to submit a PR and add me as a reviewer when you're ready.

[tirkarthi]

Thanks Emily, I am marking this as easy since it's related to tests and doesn't affect alpha release. If no one gets to this I will raise a fix for this by Sunday.

[emilyemorehouse]

New changeset 075de6c by Emily Morehouse (Joannah Nanjekye) in branch 'master':
bpo-35861: Fix SyntaxWarning in test_named_expressions.py (GH-11722)
075de6c