multiprocessing's SyncManager.dict.has_key() method is broken

[giampaolo]

BPO	35918
Nosy	@pitrou, @giampaolo, @applio, @remilapeyre
PRs	bpo-35918: Remove broken has_key method and add test #11819 bpo-35918: Remove broken has_key method and add test #11819 bpo-35918: Remove broken has_key method and add test #11819 [3.7] bpo-35918: Remove broken has_key method and add test (GH-11819) #11824

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-02-12.17:36:02.616>
created_at = <Date 2019-02-06.17:22:15.128>
labels = ['3.7', '3.8']
title = "multiprocessing's SyncManager.dict.has_key() method is broken"
updated_at = <Date 2019-02-12.17:36:02.615>
user = 'https://github.com/giampaolo'

bugs.python.org fields:

activity = <Date 2019-02-12.17:36:02.615>
actor = 'josh.r'
assignee = 'none'
closed = True
closed_date = <Date 2019-02-12.17:36:02.616>
closer = 'josh.r'
components = []
creation = <Date 2019-02-06.17:22:15.128>
creator = 'giampaolo.rodola'
dependencies = []
files = []
hgrepos = []
issue_num = 35918
keywords = ['patch', 'patch', 'patch']
message_count = 6.0
messages = ['334959', '335222', '335230', '335232', '335279', '335280']
nosy_count = 6.0
nosy_names = ['pitrou', 'giampaolo.rodola', 'jnoller', 'sbt', 'davin', 'remi.lapeyre']
pr_nums = ['11819', '11819', '11819', '11824']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue35918'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

[giampaolo]

Related to BPO-35917:

$ ./python 
Python 3.8.0a1+ (heads/master:cd90f6a369, Feb  6 2019, 17:16:10) 
[GCC 7.3.0] on linux
>>> import multiprocessing.managers
>>> m = multiprocessing.managers.SyncManager()
>>> m.start()
>>> d = m.dict()
>>> 'has_key' in dir(d)
True
>>> d.has_key(1)
Traceback (most recent call last):
  File "/home/giampaolo/cpython/Lib/multiprocessing/managers.py", line 271, in serve_client
    fallback_func = self.fallback_mapping[methodname]
KeyError: 'has_key'

[remilapeyre]

Hi @giampaolo.rodola, I will post a PR for this issue.

[remilapeyre]

has_key method has been removed in Python3 so I think we can remove it from the DictProxy as well as nobody should be relying on it anymore.

[pitrou]

That sounds fine to me.

[giampaolo]

New changeset a31f4cc by Giampaolo Rodola (Rémi Lapeyre) in branch 'master':
bpo-35918: Remove broken has_key method and add test (bpo-11819)
a31f4cc

[giampaolo]

New changeset 58f05ce by Giampaolo Rodola (Miss Islington (bot)) in branch '3.7':
bpo-35918: Remove broken has_key method and add test (GH-11819) (bpo-11824)
58f05ce