Windows: use GetNativeSystemInfo instead of GetSystemInfo

[giampaolo]

BPO	36105
Nosy	@pfmoore, @ronaldoussoren, @giampaolo, @tjguk, @zware, @eryksun, @zooba

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-02-25.14:58:22.663>
created_at = <Date 2019-02-25.10:57:16.833>
labels = ['invalid', '3.7', '3.8', 'OS-windows']
title = 'Windows: use GetNativeSystemInfo instead of GetSystemInfo'
updated_at = <Date 2019-02-25.15:28:53.145>
user = 'https://github.com/giampaolo'

bugs.python.org fields:

activity = <Date 2019-02-25.15:28:53.145>
actor = 'giampaolo.rodola'
assignee = 'none'
closed = True
closed_date = <Date 2019-02-25.14:58:22.663>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2019-02-25.10:57:16.833>
creator = 'giampaolo.rodola'
dependencies = []
files = []
hgrepos = []
issue_num = 36105
keywords = []
message_count = 4.0
messages = ['336512', '336513', '336527', '336532']
nosy_count = 7.0
nosy_names = ['paul.moore', 'ronaldoussoren', 'giampaolo.rodola', 'tim.golden', 'zach.ware', 'eryksun', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'not a bug'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36105'
versions = ['Python 2.7', 'Python 3.6', 'Python 3.7', 'Python 3.8']

[giampaolo]

This is what MS doc says about GetSystemInfo:
https://docs.microsoft.com/en-us/windows/desktop/api/sysinfoapi/nf-sysinfoapi-getsysteminfo

<<To retrieve accurate information for an application running on WOW64, call the GetNativeSystemInfo function.>>

$ grep -r GetSystemInfo
Modules/_ctypes/malloc_closure.c:        GetSystemInfo(&systeminfo);
Modules/mmapmodule.c:    GetSystemInfo(&si);
Modules/mmapmodule.c:    GetSystemInfo(&si);
Modules/posixmodule.c:        GetSystemInfo(&sysinfo);

[ronaldoussoren]

I guess it depends on what the information is used for. From a quick glance at the code I'd say that the current usage is correct, and that GetNativeSystemInfo could be used when reporting about the currently running system (for example by functions in the platform module).

[zooba]

Yeah, possibly only the CPU count one could change, but there's an ongoing discussion on another bug about whether that should return the actual count or the usable count.

32-bit processes have restrictions beyond what the system is capable of, and I believe we want those reflected in each of these cases.

[giampaolo]

It appears you guys are right. Sorry for the noise.