[2.7] Coverity scan: Modules/_hotshot.c , Variable "s1" going out of scope leaks the storage it points to.

[stratakis]

BPO	36212
Nosy	@vstinner, @stratakis
PRs	[2.7] bpo-36212: Fix two possible reference leaks in the hotshot module. #12327

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-03-14.15:11:36.784>
created_at = <Date 2019-03-06.13:57:29.035>
labels = ['extension-modules', 'performance']
title = '[2.7] Coverity scan: Modules/_hotshot.c , Variable "s1" going out of scope leaks the storage it points to.'
updated_at = <Date 2019-03-14.15:11:36.784>
user = 'https://github.com/stratakis'

bugs.python.org fields:

activity = <Date 2019-03-14.15:11:36.784>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2019-03-14.15:11:36.784>
closer = 'vstinner'
components = ['Extension Modules']
creation = <Date 2019-03-06.13:57:29.035>
creator = 'cstratak'
dependencies = []
files = []
hgrepos = []
issue_num = 36212
keywords = ['patch']
message_count = 4.0
messages = ['337301', '337930', '337931', '337932']
nosy_count = 2.0
nosy_names = ['vstinner', 'cstratak']
pr_nums = ['12327']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue36212'
versions = ['Python 2.7']

[stratakis]

Coverity scan reports a leak on _hotshot.c:

Python-2.7.15/Modules/_hotshot.c:442: alloc_arg: "unpack_string" allocates memory that is stored into "s1".
Python-2.7.15/Modules/_hotshot.c:329:5: alloc_fn: Storage is returned from allocation function "PyString_FromStringAndSize".
Python-2.7.15/Objects/stringobject.c:88:5: alloc_fn: Storage is returned from allocation function "PyObject_Malloc".
Python-2.7.15/Objects/obmalloc.c:982:5: alloc_fn: Storage is returned from allocation function "malloc".
Python-2.7.15/Objects/obmalloc.c:982:5: return_alloc_fn: Directly returning storage allocated by "malloc".
Python-2.7.15/Objects/stringobject.c:88:5: var_assign: Assigning: "op" = "PyObject_Malloc(37UL + size)".
Python-2.7.15/Objects/stringobject.c:111:5: return_alloc: Returning allocated memory "op".
Python-2.7.15/Modules/_hotshot.c:329:5: var_assign: Assigning: "*pvalue" = "PyString_FromStringAndSize(buf, len)".
Python-2.7.15/Modules/_hotshot.c:486: leaked_storage: Variable "s1" going out of scope leaks the storage it points to.
484| result = PyTuple_New(4);
485| if (result == NULL)
486|-> return NULL;
487| PyTuple_SET_ITEM(result, 0, PyInt_FromLong(what));
488| PyTuple_SET_ITEM(result, 2, PyInt_FromLong(fileno));

[vstinner]

Note for myself: Python 3 isn't affected, _hotshot module has been removed from Python 3.

[vstinner]

New changeset 2832ad5 by Victor Stinner (stratakis) in branch '2.7':
[2.7] bpo-36212: Fix two possible reference leaks in the hotshot module (GH-12327)
2832ad5

[vstinner]

Thanks Charalampos, I merged your PR. I made minor changes in your commit message.