Create test for fcntl.lockf()

[nanjekyejoannah]

BPO	36746
Nosy	@vstinner, @tiran, @corona10, @nanjekyejoannah
PRs	bpo-36746: Create test for fcntl.lockf() #12999
Superseder	bpo-22367: Add open_file_descriptor parameter to fcntl.lockf() (use the new F_OFD_SETLK flag)

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-01-15.21:37:57.704>
created_at = <Date 2019-04-28.18:32:58.421>
labels = ['3.8', 'tests']
title = 'Create test for fcntl.lockf()'
updated_at = <Date 2020-01-15.21:37:57.703>
user = 'https://github.com/nanjekyejoannah'

bugs.python.org fields:

activity = <Date 2020-01-15.21:37:57.703>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2020-01-15.21:37:57.704>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2019-04-28.18:32:58.421>
creator = 'nanjekyejoannah'
dependencies = []
files = []
hgrepos = []
issue_num = 36746
keywords = ['patch']
message_count = 6.0
messages = ['341031', '341032', '341034', '358342', '358344', '360076']
nosy_count = 4.0
nosy_names = ['vstinner', 'christian.heimes', 'corona10', 'nanjekyejoannah']
pr_nums = ['12999']
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '22367'
type = None
url = 'https://bugs.python.org/issue36746'
versions = ['Python 3.8']

[nanjekyejoannah]

We need to implement a test for fcntl.lockf().

[nanjekyejoannah]

I have opened a PR with this test. If you think its great, we can use the same test to test posix.lock(). The one I have written in more detailed than the current test for posix.lock().

[nanjekyejoannah]

I have opened a PR with this test. If you think its great, we can use the same test to test posix.lockf(). The one I have written in more detailed than the current test for posix.lockf().

Correcting the above comment.

[corona10]

@nanjekyejoannah

IMHO, tests were added through bpo-22367
I think that we can close this issue.
What do you think?

[nanjekyejoannah]

@victor looks to be the author of the change the introduced the tests that can resolve this.

Victor, can we consider this closed. I have no problem closing the issue and the related PR.

[vstinner]

PR bpo-17010 of bpo-22367 added tests for fcntl.lockf(). I close this PR as a duplicate of bpo-22367. Thanks @nanjekyejoannah anyway!