Python 2.7 setup.py incorrectly double-joins SDKROOT

[mistydemeo]

BPO	37285
Nosy	@ned-deily, @mistydemeo
PRs	bpo-37285: setup.py: avoid joining the SDKROOT twice #14095
Superseder	bpo-36231: Support builds on macOS without installed system header files

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ned-deily'
closed_at = <Date 2019-10-19.09:57:29.486>
created_at = <Date 2019-06-14.18:29:57.903>
labels = ['build']
title = 'Python 2.7 setup.py incorrectly double-joins SDKROOT'
updated_at = <Date 2019-10-19.09:57:29.485>
user = 'https://github.com/mistydemeo'

bugs.python.org fields:

activity = <Date 2019-10-19.09:57:29.485>
actor = 'ned.deily'
assignee = 'ned.deily'
closed = True
closed_date = <Date 2019-10-19.09:57:29.486>
closer = 'ned.deily'
components = ['Build']
creation = <Date 2019-06-14.18:29:57.903>
creator = 'mistydemeo'
dependencies = []
files = []
hgrepos = []
issue_num = 37285
keywords = ['patch']
message_count = 2.0
messages = ['345626', '354935']
nosy_count = 2.0
nosy_names = ['ned.deily', 'mistydemeo']
pr_nums = ['14095']
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '36231'
type = 'compile error'
url = 'https://bugs.python.org/issue37285'
versions = ['Python 2.7']

[mistydemeo]

Python 2.7's setup.py has incorrect behaviour when adding the SDKROOT to the beginning of the include path while searching.

When searching paths, find_file first checks is_macosx_sdk_path to see if it needs to add the sdk_root: https://github.com/python/cpython/blob/2.7/setup.py#L87-L88

This is mostly correct, except one of the path prefixes it checks is /Library: https://github.com/python/cpython/blob/2.7/setup.py#L64

The Xcode CLT path is located in /Library, so this check passes. That means the /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk portion of the path gets repeated, leading to an invalid path.

I recognize Python 2.7 isn't in active development, but I have a minimal patch to fix this that I will be submitting.

[ned-deily]

Thanks for the report and the PR (and sorry for the delay in responding). There were several problems with building on macOS without installed header files, which is no longer supported in the most recent Xcode / Command Line Tools releases, as well as a problem specific to 2.7 which caused such builds to not find the system zlib. All of these issues were addressed in the changes for bpo-36231 (c421c66) and bpo-19960 (da7f6db) which were merged to 2.7 a few months ago and are being released with 2.7.17. With these changes, the double-join problem your PR was correcting no longer occur.