Move _Py_IDENTIFIER statics in Python/import.c to top of the file

[nanjekyejoannah]

BPO	37872
Nosy	@vstinner, @ericsnowcurrently, @serhiy-storchaka, @gnprice, @nanjekyejoannah

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/nanjekyejoannah'
closed_at = <Date 2019-09-11.13:44:16.431>
created_at = <Date 2019-08-16.13:21:10.641>
labels = ['interpreter-core', 'type-feature', 'library', '3.9']
title = 'Move _Py_IDENTIFIER statics in Python/import.c to top of the file'
updated_at = <Date 2019-09-11.13:44:16.431>
user = 'https://github.com/nanjekyejoannah'

bugs.python.org fields:

activity = <Date 2019-09-11.13:44:16.431>
actor = 'eric.snow'
assignee = 'nanjekyejoannah'
closed = True
closed_date = <Date 2019-09-11.13:44:16.431>
closer = 'eric.snow'
components = ['Interpreter Core', 'Library (Lib)']
creation = <Date 2019-08-16.13:21:10.641>
creator = 'nanjekyejoannah'
dependencies = []
files = []
hgrepos = []
issue_num = 37872
keywords = []
message_count = 5.0
messages = ['349859', '349860', '349861', '350065', '351878']
nosy_count = 5.0
nosy_names = ['vstinner', 'eric.snow', 'serhiy.storchaka', 'Greg Price', 'nanjekyejoannah']
pr_nums = []
priority = 'normal'
resolution = 'rejected'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue37872'
versions = ['Python 3.9']

[nanjekyejoannah]

Following a PR review here: #15057 by @ericsnowcurrently i.e :

Please move both these statics to the top of the file (next to CACHEDIR) as globals.

To keep the diff in the above PR simple, I am tracking this refactor in this issue.

[nanjekyejoannah]

Relevant comment from @gnprice.

I think it would be better to make that as a separate change. This style where they're block-local is the way the existing code works, which keeps the diff simple.

It's also the way that every use of _Py_IDENTIFIER in this file works. So I think the cleanest way to change the style would be to sweep through this whole file (or more) in one PR, separate from any substantive changes.

[nanjekyejoannah]

Keeping this until the PR #15057 is merged.

[vstinner]

Why should we move static variables as globals? What is the rationale?

_Py_IDENTIFIER uses a linked list internally to be able to free all these strings at Python exit.

[ericsnowcurrently]

Yeah, I'm fine with dropping this. In the file we have some global and some local, so my suggestion was to consolidate a little. However, it mostly doesn't matter. :)