off-by-one error in PyState_AddModule

[benjaminp]

BPO	38124
Nosy	@benjaminp, @miss-islington
PRs	closes bpo-38124: Fix bounds check in PyState_AddModule. #16007 [3.8] closes bpo-38124: Fix bounds check in PyState_AddModule. (GH-16007) #16008 [3.7] closes bpo-38124: Fix bounds check in PyState_AddModule. (GH-16007) #16009

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-09-11.23:43:25.589>
created_at = <Date 2019-09-11.23:08:38.502>
labels = ['interpreter-core', '3.8', 'type-bug', '3.7', '3.9']
title = 'off-by-one error in PyState_AddModule'
updated_at = <Date 2019-09-12.00:04:30.236>
user = 'https://github.com/benjaminp'

bugs.python.org fields:

activity = <Date 2019-09-12.00:04:30.236>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2019-09-11.23:43:25.589>
closer = 'benjamin.peterson'
components = ['Interpreter Core']
creation = <Date 2019-09-11.23:08:38.502>
creator = 'benjamin.peterson'
dependencies = []
files = []
hgrepos = []
issue_num = 38124
keywords = ['patch']
message_count = 4.0
messages = ['352031', '352033', '352035', '352036']
nosy_count = 2.0
nosy_names = ['benjamin.peterson', 'miss-islington']
pr_nums = ['16007', '16008', '16009']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue38124'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

[benjaminp]

cpython/Python/pystate.c

Line 707 in 3f4db4a

if(module == PyList_GET_ITEM(state->modules_by_index, index)) {

should be using > not >=.

[benjaminp]

New changeset 39de95b by Benjamin Peterson in branch 'master':
closes bpo-38124: Fix bounds check in PyState_AddModule. (GH-16007)
39de95b

[miss-islington]

New changeset 8892a1d by Miss Islington (bot) in branch '3.7':
closes bpo-38124: Fix bounds check in PyState_AddModule. (GH-16007)
8892a1d

[miss-islington]

New changeset a5a7102 by Miss Islington (bot) in branch '3.8':
closes bpo-38124: Fix bounds check in PyState_AddModule. (GH-16007)
a5a7102