single-argument form of -isysroot should be supported

[jmroot]

BPO	38360
Nosy	@ronaldoussoren, @ned-deily, @merwok, @jmroot, @dstufft, @miss-islington
PRs	bpo-38360: macOS: support alternate form of -isysroot flag #16480 [3.7] bpo-38360: macOS: support alternate form of -isysroot flag (GH-16480) #19657 [3.8] bpo-38360: macOS: support alternate form of -isysroot flag (GH-16480) #19658

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ned-deily'
closed_at = <Date 2020-04-22.07:53:20.460>
created_at = <Date 2019-10-03.11:20:54.494>
labels = ['OS-mac', 'type-bug', '3.8', '3.9', '3.7', 'library']
title = 'single-argument form of -isysroot should be supported'
updated_at = <Date 2020-04-22.17:21:50.180>
user = 'https://github.com/jmroot'

bugs.python.org fields:

activity = <Date 2020-04-22.17:21:50.180>
actor = 'ned.deily'
assignee = 'ned.deily'
closed = True
closed_date = <Date 2020-04-22.07:53:20.460>
closer = 'ned.deily'
components = ['Distutils', 'macOS']
creation = <Date 2019-10-03.11:20:54.494>
creator = 'jmr'
dependencies = []
files = []
hgrepos = []
issue_num = 38360
keywords = []
message_count = 7.0
messages = ['353838', '356046', '366990', '366991', '366997', '367017', '367027']
nosy_count = 6.0
nosy_names = ['ronaldoussoren', 'ned.deily', 'eric.araujo', 'jmr', 'dstufft', 'miss-islington']
pr_nums = ['16480', '19657', '19658']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue38360'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

[jmroot]

The path associated with the -isysroot compiler flag can be supplied either as a separate argument or in the same argument as -isysroot itself. The places in library code that do special handling of this flag should support both forms, but currently only support the two separate arguments form. This means that the flag may not be removed when pointing to a nonexistent SDK or when a different SDK is specified in the user's CFLAGS, and at worst a ValueError is raised in compiler_fixup.

[jmroot]

Ping?

[ned-deily]

New changeset b310700 by Joshua Root in branch 'master':
bpo-38360: macOS: support alternate form of -isysroot flag (GH-16480)
b310700

[ned-deily]

Thanks for the PR! This seems like a borderline feature rather than a bug so, unless there is a compelling reason to backport it to 3.8.x, I'm just going to push it to master for release in 3.9.0 (as of alpha 6).

[jmroot]

That ValueError I mentioned causes build failures for extension modules whenever the CFLAGS in sysconfig contains an -isysroot flag in the single arg form. We ran into it a lot in MacPorts on Mojave and Catalina. So I would consider it a bug, and would prefer to backport to all branches that are open for bug fixes.

[miss-islington]

New changeset e7f8684 by Miss Islington (bot) in branch '3.7':
bpo-38360: macOS: support alternate form of -isysroot flag (GH-16480)
e7f8684

[miss-islington]

New changeset 4a6da0b by Miss Islington (bot) in branch '3.8':
bpo-38360: macOS: support alternate form of -isysroot flag (GH-16480)
4a6da0b