Remove or change "Multithreading" section

[greatvovan]

BPO	38413
Nosy	@berkerpeksag, @dimaqq, @miss-islington, @greatvovan
PRs	bpo-38413: Improve documentation of sqlite3 module #23159 [3.8] bpo-38413: Remove outdated section about multithreading in sqlite3 (GH-23159) #24134 [3.9] bpo-38413: Remove outdated section about multithreading in sqlite3 (GH-23159) #24145

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-01-06.19:32:20.614>
created_at = <Date 2019-10-08.19:30:42.578>
labels = ['type-bug', '3.8', '3.9', '3.10', 'docs']
title = 'Remove or change "Multithreading" section'
updated_at = <Date 2021-01-06.20:58:40.547>
user = 'https://github.com/greatvovan'

bugs.python.org fields:

activity = <Date 2021-01-06.20:58:40.547>
actor = 'berker.peksag'
assignee = 'docs@python'
closed = True
closed_date = <Date 2021-01-06.19:32:20.614>
closer = 'Vladimir Ryabtsev'
components = ['Documentation']
creation = <Date 2019-10-08.19:30:42.578>
creator = 'Vladimir Ryabtsev'
dependencies = []
files = []
hgrepos = []
issue_num = 38413
keywords = ['patch']
message_count = 8.0
messages = ['354227', '354305', '379818', '379820', '379821', '384453', '384454', '384540']
nosy_count = 6.0
nosy_names = ['ghaering', 'docs@python', 'berker.peksag', 'Dima.Tisnek', 'miss-islington', 'Vladimir Ryabtsev']
pr_nums = ['23159', '24134', '24145']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue38413'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

[greatvovan]

This is regarding the page https://docs.python.org/3.7/library/sqlite3.html.

I believe this section on the very bottom of the page has been kept here for pretty long time, during that both SQLite and the sqlite3 module evolved and improved. Now the content contradicts to the description of function "connect()" in the part describing "check_same_thread" parameter. The function description says that using connections from multiple threads is allowed with serialization handled by the user (and it is true), while the bottom "Mutithreading" section says sharing connections is not allowed.

I think we can remove "Mutithreading" section entirely unless there is something important to add to what already mentioned.

[dimaqq]

That would be nice; someone needs to figure out what exact sqlite version allows safe passing of connection between threads. Ideally other caveats would be covered (is passing open cursors to another thread allowed?, etc...)

[greatvovan]

I see no point in researching the version of sqlite, since Python does not allow user to specify it, you just use the compiled version that comes with Python distribution.

10 years now to the commit that introduced that piece of text: c34d76c

Let's just remove it, what it says is simply not true.

[greatvovan]

May by I was wrong above and it uses system's Sqlite... But anyway it does not cancel the fact that this section contradicts to another one.

[greatvovan]

Also the footnote requires some minor corrections (formatting and style). I suggest the following wording:

To get loadable extension support, your Python must be compiled with -–enable-loadable-sqlite-extensions option in PYTHON_CONFIGURE_OPTS.

I believe otherwise it is basically not clear what is said here.

[berkerpeksag]

New changeset f9949f8 by Vladimir in branch 'master':
bpo-38413: Remove outdated section about multithreading in sqlite3 (GH-23159)
f9949f8

[berkerpeksag]

New changeset 03a079f by Miss Islington (bot) in branch '3.8':
bpo-38413: Remove outdated section about multithreading in sqlite3 (GH-23159)
03a079f