Path.home() should ignore HOME env var like os.path.expanduser()

[lazka]

BPO	38883
Nosy	@brettcannon, @zooba, @lazka, @asottile, @miss-islington, @isidentical
PRs	bpo-38883: Don't honor POSIX HOME in pathlib.Path.home/expanduser on Windows #17961 [3.8] bpo-38883: Don't use POSIX $HOME in pathlib.Path.home/expanduser on Windows (GH-17961) #18229

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-01-28.09:59:05.741>
created_at = <Date 2019-11-21.18:45:12.057>
labels = ['3.8', 'library', '3.9']
title = 'Path.home() should ignore HOME env var like os.path.expanduser()'
updated_at = <Date 2020-01-28.09:59:47.636>
user = 'https://github.com/lazka'

bugs.python.org fields:

activity = <Date 2020-01-28.09:59:47.636>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2020-01-28.09:59:05.741>
closer = 'steve.dower'
components = ['Library (Lib)']
creation = <Date 2019-11-21.18:45:12.057>
creator = 'lazka'
dependencies = []
files = []
hgrepos = []
issue_num = 38883
keywords = ['patch']
message_count = 4.0
messages = ['357196', '360847', '360852', '360854']
nosy_count = 6.0
nosy_names = ['brett.cannon', 'steve.dower', 'lazka', 'Anthony Sottile', 'miss-islington', 'BTaskaya']
pr_nums = ['17961', '18229']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue38883'
versions = ['Python 3.8', 'Python 3.9']

[lazka]

In bpo-36264 os.path.expanduser() was changed to no longer use the HOME environment variable on Windows.

There are two more ways in the stdlib to get the user directory, pathlib.Path.home() and pathlib.Path.expanduser() which internally use gethomedir() which still uses the HOME environment variable:

cpython/Lib/pathlib.py

Line 255 in 0aca3a3

def gethomedir(self, username):

Since they are documented to work the same as os.path.expanduser() they should be changed to no longer use HOME as well.

[zooba]

New changeset c45a2aa by Steve Dower (Christoph Reiter) in branch 'master':
bpo-38883: Don't use POSIX $HOME in pathlib.Path.home/expanduser on Windows (GH-17961)
c45a2aa

[zooba]

Thanks, Christoph!

[miss-islington]

New changeset 595b516 by Miss Islington (bot) in branch '3.8':
bpo-38883: Don't use POSIX $HOME in pathlib.Path.home/expanduser on Windows (GH-17961)
595b516