TimeoutError behavior changes on async.wait_for from python3.7

[YerkenTussupbekov]

BPO	41438
Nosy	@asvetlov, @1st1

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2020-07-29.22:17:28.177>
labels = ['type-bug', '3.8', 'expert-asyncio']
title = 'TimeoutError behavior changes on async.wait_for from python3.7'
updated_at = <Date 2020-07-29.22:28:39.708>
user = 'https://bugs.python.org/YerkenTussupbekov'

bugs.python.org fields:

activity = <Date 2020-07-29.22:28:39.708>
actor = 'yselivanov'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['asyncio']
creation = <Date 2020-07-29.22:17:28.177>
creator = 'Yerken Tussupbekov'
dependencies = []
files = []
hgrepos = []
issue_num = 41438
keywords = []
message_count = 2.0
messages = ['374589', '374591']
nosy_count = 3.0
nosy_names = ['asvetlov', 'yselivanov', 'Yerken Tussupbekov']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41438'
versions = ['Python 3.8']

[YerkenTussupbekov]

import asyncio
from concurrent import futures


logging.basicConfig(
    level=logging.DEBUG,
    format="[%(asctime)s %(name)s %(levelname)s]: %(message)s",
    datefmt="%H:%M:%S %d-%m-%y",
)
logger: logging.Logger = logging.getLogger("ideahitme")


async def too_long() -> None:
    await asyncio.sleep(2)


async def run() -> None:
    try:
        await asyncio.wait_for(too_long(), 1)
    except futures.TimeoutError:
        logger.info("concurrent.futures.TimeoutError happened")
    except asyncio.TimeoutError:
        logger.info("asyncio.TimeoutError happened")


if __name__ == "__main__":
    asyncio.run(run())

In python 3.8.4 running this script will print:

asyncio.TimeoutError happened

In python 3.7.5 running this script will print:

concurrent.futures.TimeoutError happened

This is a breaking change which I didn't see announced in the changelog. What is the expected behavior here ?

[1st1]

In python 3.8.4 running this script will print:

asyncio.TimeoutError happened

This is the expected behavior in 3.8.

This is a breaking change which I didn't see announced in the changelog.

Yeah, looks like this wasn't mentioned in what's new or elsewhere in the docs. :(

Do you want to submit a PR to fix that?

[kumaraditya303]

TimeoutError is now an alias of builtin TimeoutError.