Potential UnicodeDecodeError in dis

[zkonge]

BPO	41497
Nosy	@methane, @serhiy-storchaka, @miss-islington, @zkonge
PRs	bpo-41497: Fix potential UnicodeDecodeError in dis #21757 [3.9] bpo-41497: Fix potential UnicodeDecodeError in dis CLI (GH-21757) #21782 [3.8] bpo-41497: Fix potential UnicodeDecodeError in dis CLI (GH-21757) #21783

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-08-08.03:38:50.058>
created_at = <Date 2020-08-06.19:52:45.184>
labels = ['3.8', 'type-bug', 'library', '3.9', '3.10']
title = 'Potential UnicodeDecodeError in dis'
updated_at = <Date 2020-08-08.03:38:50.057>
user = 'https://github.com/zkonge'

bugs.python.org fields:

activity = <Date 2020-08-08.03:38:50.057>
actor = 'methane'
assignee = 'none'
closed = True
closed_date = <Date 2020-08-08.03:38:50.058>
closer = 'methane'
components = ['Library (Lib)']
creation = <Date 2020-08-06.19:52:45.184>
creator = 'zkonge'
dependencies = []
files = []
hgrepos = []
issue_num = 41497
keywords = ['patch']
message_count = 6.0
messages = ['374961', '374965', '374977', '375032', '375034', '375035']
nosy_count = 4.0
nosy_names = ['methane', 'serhiy.storchaka', 'miss-islington', 'zkonge']
pr_nums = ['21757', '21782', '21783']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41497'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

[zkonge]

A potential UnicodeDecodeError could be raised when run "python -m dis" on non-utf8 encoding environment.

Assume there is a file named "a.py", and contains "print('喵')", then save with UTF8 encoding.

Run "python -m dis ./a.py", on non-UTF8 encoding environment, for example a Windows PC which default language is Chinese.

A UnicodeDecodeError raised.

Traceback (most recent call last):
  File "C:\Program Files\Python38\lib\runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files\Python38\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Program Files\Python38\lib\dis.py", line 553, in <module>
    _test()
  File "C:\Program Files\Python38\lib\dis.py", line 548, in _test
    source = infile.read()
UnicodeDecodeError: 'gbk' codec can't decode byte 0xb5 in position 9: illegal multibyte sequence

That because Windows' default encoding is decided by language. Chinese use cp936(GB2312) as default encoding and can't handle UTF8 encoding.

It just need to read in "rb" mode instead of "r".

[zkonge]

I searched the whole Lib folder and find a lot of code uses "open(filename, 'r')" without handling default encoding.

Should we open another issue for these problem?