PR proceeds to "awaiting core review" when changes are requested

[iritkatriel]

BPO	41554
Nosy	@ericvsmith, @FFY00, @iritkatriel

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-08-14.16:47:33.378>
created_at = <Date 2020-08-14.13:41:49.038>
labels = ['type-bug', 'invalid']
title = 'PR proceeds to "awaiting core review" when changes are requested'
updated_at = <Date 2020-08-14.16:47:33.377>
user = 'https://github.com/iritkatriel'

bugs.python.org fields:

activity = <Date 2020-08-14.16:47:33.377>
actor = 'iritkatriel'
assignee = 'none'
closed = True
closed_date = <Date 2020-08-14.16:47:33.378>
closer = 'iritkatriel'
components = []
creation = <Date 2020-08-14.13:41:49.038>
creator = 'iritkatriel'
dependencies = []
files = []
hgrepos = []
issue_num = 41554
keywords = []
message_count = 3.0
messages = ['375404', '375407', '375417']
nosy_count = 3.0
nosy_names = ['eric.smith', 'FFY00', 'iritkatriel']
pr_nums = []
priority = 'normal'
resolution = 'not a bug'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41554'
versions = []

[iritkatriel]

When I click on "review" I get three options: comment, approve,
and request changes. I assumed that "request changes"
would block the PR until the changes were made, but instead in the
case of PR 19046 it proceeded to "awaiting core review",
which seems to imply that it passed the first review.

[ericvsmith]

I think this belongs under https://github.com/python/bedevere

[iritkatriel]

It appears (as per core-mentoring list) that this is the intended behavior.