Compiler error in _zoneinfo.c:1227: error: #pragma GCC diagnostic not allowed inside functions

[micwin]

BPO	41864
Nosy	@ambv, @pganssle, @corona10
Superseder	bpo-40686: Compiler warnings in _zoneinfo.c on Windows build in 64-bit

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2022-03-19.16:11:10.924>
created_at = <Date 2020-09-26.10:04:51.397>
labels = ['build', '3.9']
title = 'Compiler error in _zoneinfo.c:1227: error: #pragma GCC diagnostic not allowed inside functions'
updated_at = <Date 2022-03-19.16:11:10.924>
user = 'https://bugs.python.org/micwin'

bugs.python.org fields:

activity = <Date 2022-03-19.16:11:10.924>
actor = 'iritkatriel'
assignee = 'none'
closed = True
closed_date = <Date 2022-03-19.16:11:10.924>
closer = 'iritkatriel'
components = ['Build']
creation = <Date 2020-09-26.10:04:51.397>
creator = 'micwin'
dependencies = []
files = []
hgrepos = []
issue_num = 41864
keywords = []
message_count = 2.0
messages = ['377520', '377531']
nosy_count = 4.0
nosy_names = ['lukasz.langa', 'p-ganssle', 'corona10', 'micwin']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '40686'
type = 'compile error'
url = 'https://bugs.python.org/issue41864'
versions = ['Python 3.9']

[micwin]

Python 3.9.0rc2
OS: centos 6.10
Compiler: gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23)

configure && make

Python-3.9.0rc2/Modules/_zoneinfo.c:1227: error: #pragma GCC diagnostic not allowed inside functions
Python-3.9.0rc2/Modules/_zoneinfo.c:1228: error: #pragma GCC diagnostic not allowed inside functions
Python-3.9.0rc2/Modules/_zoneinfo.c:1229: warning: comparison is always false due to limited range of data type
Python-3.9.0rc2/Modules/_zoneinfo.c:1230: error: #pragma GCC diagnostic not allowed inside functions

Proposed fix, here the diff:

1227d1226
< #if defined(GNUC) && __GNUC__ >= 5
1230d1228
< #endif
1232d1229
< #if defined(GNUC) && __GNUC__ >= 5
1234d1230
< #endif

[corona10]

see also: https://bugs.python.org/issue40686