-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the example code in Doc/extending/extending.rst to declare and initialize the pmodule variable to be of the right type. #87905
Comments
In the example code of the Extending Python with C/C++ documentation the pmodule variable (that stores the return value of PyImport_ImportModule) was never declared. The PR(s) attached to this issue fixes it by declaring and initializing the pmodule variable. This issue is common in all the documentation versions. The first PR will be for documentation version 3.10. If it's accepted then I would request other developers to submit PRs for documentation 3.9, 3.8, 3.7 and 3.6 because I'm having a problem switching to those branches (I'm continuously facing the problem "HEAD detached" if I switch to those branches). Thanking you With Regards |
Please have a review of my change in the documentation. (Note: I have not signed the Python CLA because I think a simple fix in the documentation doesn't require it.) |
Please have a review. |
I've signed the PSF CLA (as it is required) now. Please have a review. |
I've managed to overcome the "HEAD Detached" problem I was facing when switching to the 3.9, 3.8, 3.7 and 3.6 branches. So I'm also submitting the PRs for those documentation versions. |
Documentation versions older than 3.8 describes a different approach to import the module. Therefore those documentation versions are not to be messed with. I've attached the PRs for documentation versions 3.10, 3.9 and 3.8. Please anyone have a review of my PR as soon as possible. Thanking you, With Regards |
New changeset ea9b2d6 by Shreyan Avigyan in branch 'master': |
New changeset 3a3c046 by Miss Islington (bot) in branch '3.8': |
New changeset 28fb2d1 by Miss Islington (bot) in branch '3.9': |
Thanks for the PR |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: