Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_peg_generator is extremely slow #90734

Closed
gpshead opened this issue Jan 29, 2022 · 8 comments
Closed

test_peg_generator is extremely slow #90734

gpshead opened this issue Jan 29, 2022 · 8 comments
Assignees
Labels
3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes tests Tests in the Lib/test dir

Comments

@gpshead
Copy link
Member

gpshead commented Jan 29, 2022

BPO 46576
Nosy @gpshead, @jkloth, @miss-islington, @tirkarthi
PRs
  • bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. #31015
  • [3.10] bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator #31089
  • [3.9] [3.10] bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. (GH-31015) (GH-31089) #31093
  • bpo-46576: Speed up test_peg_generator by using a static library for shared sources #32338
  • [3.10] bpo-46576: Speed up test_peg_generator by using a static libra… #32382
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gpshead'
    closed_at = <Date 2022-02-03.08:25:22.004>
    created_at = <Date 2022-01-29.20:31:42.298>
    labels = ['tests', '3.9', '3.10', '3.11']
    title = 'test_peg_generator is extremely slow'
    updated_at = <Date 2022-04-06.22:22:07.128>
    user = 'https://github.com/gpshead'

    bugs.python.org fields:

    activity = <Date 2022-04-06.22:22:07.128>
    actor = 'jkloth'
    assignee = 'gregory.p.smith'
    closed = True
    closed_date = <Date 2022-02-03.08:25:22.004>
    closer = 'gregory.p.smith'
    components = ['Tests']
    creation = <Date 2022-01-29.20:31:42.298>
    creator = 'gregory.p.smith'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 46576
    keywords = ['patch']
    message_count = 8.0
    messages = ['412104', '412125', '412396', '412416', '412418', '412424', '416797', '416902']
    nosy_count = 4.0
    nosy_names = ['gregory.p.smith', 'jkloth', 'miss-islington', 'xtreak']
    pr_nums = ['31015', '31089', '31093', '32338', '32382']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'commit review'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue46576'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    @gpshead
    Copy link
    Member Author

    gpshead commented Jan 29, 2022

    test_peg_generator is an extremely slow test. This bug tracks any changes to reduce its runtime and test latency.

    @gpshead gpshead added 3.11 bug and security fixes tests Tests in the Lib/test dir labels Jan 29, 2022
    @tirkarthi
    Copy link
    Member

    See also bpo-46524 for a similar discussion.

    @gpshead
    Copy link
    Member Author

    gpshead commented Feb 2, 2022

    New changeset 164a017 by Gregory P. Smith in branch 'main':
    bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. (bpo-31015)
    164a017

    @gpshead
    Copy link
    Member Author

    gpshead commented Feb 3, 2022

    New changeset f5ebec4 by Gregory P. Smith in branch '3.10':
    [3.10] bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. (GH-31015) (GH-31089)
    f5ebec4

    @miss-islington
    Copy link
    Contributor

    New changeset e825860 by Miss Islington (bot) in branch '3.9':
    [3.9] [3.10] bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. (GH-31015) (GH-31089) (GH-31093)
    e825860

    @gpshead
    Copy link
    Member Author

    gpshead commented Feb 3, 2022

    for my purposes those PRs make it reasonable, even though it remains one of our slowest tests. we can reopen/reuse this issue for any further test_peg_generator performance improvements as needed.

    @gpshead gpshead added 3.9 only security fixes 3.10 only security fixes labels Feb 3, 2022
    @gpshead gpshead closed this as completed Feb 3, 2022
    @gpshead gpshead self-assigned this Feb 3, 2022
    @gpshead gpshead added 3.9 only security fixes 3.10 only security fixes labels Feb 3, 2022
    @gpshead gpshead closed this as completed Feb 3, 2022
    @gpshead gpshead self-assigned this Feb 3, 2022
    @jkloth
    Copy link
    Contributor

    jkloth commented Apr 5, 2022

    My PR-32338 further reduces the runtime of the test another ~25%.

    On my machine, before 85s, after 65s.

    @gpshead
    Copy link
    Member Author

    gpshead commented Apr 6, 2022

    New changeset 612e422 by Jeremy Kloth in branch 'main':
    bpo-46576: Speed up test_peg_generator by using a static library for shared sources (GH-32338)
    612e422

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes tests Tests in the Lib/test dir
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants