[3.11] gh-99952: fix refcount issues in ctypes.Structure from_param() result #101339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esult. (pythonGH-100169) Fixes a reference counting issue with `ctypes.Structure` when a `from_param()` method call is used and the structure size is larger than a C pointer `sizeof(void*)`. This problem existed for a very long time, but became more apparent in 3.8+ by change likely due to garbage collection cleanup timing changes.. (cherry picked from commit dfad678) Co-authored-by: Yukihiro Nakadaira <yukihiro.nakadaira@gmail.com>
gpshead
added
type-bug
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-101340 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 26, 2023
…aram() result (pythonGH-101339) [3.11] pythongh-99952: [ctypes] fix refcount issues in from_param() result. (pythonGH-100169) Fixes a reference counting issue with `ctypes.Structure` when a `from_param()` method call is used and the structure size is larger than a C pointer `sizeof(void*)`. This problem existed for a very long time, but became more apparent in 3.8+ by change likely due to garbage collection cleanup timing changes.. (cherry picked from commit dfad678) (cherry picked from commit fa7c37a) Co-authored-by: Gregory P. Smith <greg@krypto.org> Co-authored-by: Yukihiro Nakadaira <yukihiro.nakadaira@gmail.com>
gpshead
added a commit
that referenced
this pull request
Feb 4, 2023
…param() result (GH-101339) (#101340) [3.11] gh-99952: [ctypes] fix refcount issues in from_param() result. (GH-100169) Fixes a reference counting issue with `ctypes.Structure` when a `from_param()` method call is used and the structure size is larger than a C pointer `sizeof(void*)`. This problem existed for a very long time, but became more apparent in 3.8+ by change likely due to garbage collection cleanup timing changes.. (cherry picked from commit dfad678) (cherry picked from commit fa7c37a) Co-authored-by: Gregory P. Smith <greg@krypto.org> Co-authored-by: Yukihiro Nakadaira <yukihiro.nakadaira@gmail.com> Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #100169
Fixes a reference counting issue with
ctypes.Structurewhen afrom_param()method call is used and the structure size is larger than a C pointersizeof(void*).This problem existed for a very long time, but became more apparent in 3.8+ by change likely due to garbage collection cleanup timing changes.. (cherry picked from commit dfad678)
Co-authored-by: Yukihiro Nakadaira yukihiro.nakadaira@gmail.com
ctypes.WINFUNCTYPEworks in Python3.7, does not work as same in newer Python #99952