bpo-35091: Objects/listobject.c: Don't rely on signed int overflow in…#10184
Closed
izbyshev wants to merge 1 commit intopython:masterfrom
Closed
bpo-35091: Objects/listobject.c: Don't rely on signed int overflow in…#10184izbyshev wants to merge 1 commit intopython:masterfrom
izbyshev wants to merge 1 commit intopython:masterfrom
Conversation
… gallop functions Signed integer overflow is undefined behavior. Use unsigned types instead.
| assert(lastofs <= ofs && ofs <= (size_t)n); | ||
| /* Now a[lastofs-1] < key <= a[ofs], so key belongs somewhere to the | ||
| * right of lastofs-1 but no farther right than ofs. Do a binary | ||
| * search, with invariant a[lastofs-1] < key <= a[ofs]. |
Member
There was a problem hiding this comment.
Suggested change
| * search, with invariant a[lastofs-1] < key <= a[ofs]. | |
| * search, with invariant a[lastofs] < key <= a[ofs]. |
Contributor
Author
There was a problem hiding this comment.
Unlike the first part of the comment, the last line seems to refer to the invariant holding after ++lastofs, which I moved higher. Therefore, no correction is needed.
| assert(lastofs <= ofs && ofs <= (size_t)n); | ||
| /* Now a[lastofs-1] <= key < a[ofs], so key belongs somewhere to the | ||
| * right of lastofs-1 but no farther right than ofs. Do a binary | ||
| * search, with invariant a[lastofs-1] <= key < a[ofs]. |
Member
There was a problem hiding this comment.
Suggested change
| * search, with invariant a[lastofs-1] <= key < a[ofs]. | |
| * search, with invariant a[lastofs] <= key < a[ofs]. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… gallop functions
Signed integer overflow is undefined behavior. Use unsigned types instead.
https://bugs.python.org/issue35091