Skip to content

Fix an incorrect comment in iobase_is_closed #102952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Fix an incorrect comment in iobase_is_closed #102952

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2af0eb8
Fix an incorrect comment
JonathonReinhart Mar 23, 2023
afd0e94
Merge branch 'main' into iobase-internal-closed
serhiy-storchaka Jan 16, 2024
42792e1
Move to the related comment.
serhiy-storchaka Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions Modules/_io/iobase.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,19 @@ PyDoc_STRVAR(iobase_doc,
"with open('spam.txt', 'r') as fp:\n"
" fp.write('Spam and eggs!')\n");

/* Use this macro whenever you want to check the internal `closed` status

/* Internal methods */

/* Use this function whenever you want to check the internal `closed` status
of the IOBase object rather than the virtual `closed` attribute as returned
by whatever subclass. */

static int
iobase_is_closed(PyObject *self)
{
return PyObject_HasAttrWithError(self, &_Py_ID(__IOBase_closed));
}

/* Internal methods */
static PyObject *
iobase_unsupported(_PyIO_State *state, const char *message)
{
Expand Down Expand Up @@ -145,14 +152,6 @@ _io__IOBase_truncate_impl(PyObject *self, PyTypeObject *cls,
return iobase_unsupported(state, "truncate");
}

static int
iobase_is_closed(PyObject *self)
{
/* This gets the derived attribute, which is *not* __IOBase_closed
in most cases! */
return PyObject_HasAttrWithError(self, &_Py_ID(__IOBase_closed));
}

/* Flush and close methods */

/*[clinic input]
Expand Down