Skip to content

gh-55664: Add warning when creating a type using a namespace dictionary with non-string keys. #105338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jan 28, 2024
Merged

gh-55664: Add warning when creating a type using a namespace dictionary with non-string keys. #105338

merged 16 commits into from
Jan 28, 2024

Conversation

@furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Jun 5, 2023 •
edited
Loading

@bedevere-bot bedevere-bot mentioned this pull request Oct 7, 2022
Closed
@furkanonder furkanonder marked this pull request as ready for review June 5, 2023 21:04
@furkanonder furkanonder requested a review from markshannon as a code owner June 5, 2023 21:04
@furkanonder furkanonder changed the title GH-55664: Add warning when creating a type using a namespace dictionary with no… GH-55664: Add warning when creating a type using a namespace dictionary with non-string keys. Jun 5, 2023
@furkanonder furkanonder added type-feature A feature request or enhancement interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Aug 6, 2023
@furkanonder furkanonder changed the title GH-55664: Add warning when creating a type using a namespace dictionary with non-string keys. gh-55664: Add warning when creating a type using a namespace dictionary with non-string keys. Aug 6, 2023
serhiy-storchaka
serhiy-storchaka reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name_of_class is leaked.

serhiy-storchaka
serhiy-storchaka reviewed Jan 24, 2024
View reviewed changes
serhiy-storchaka
serhiy-storchaka reviewed Jan 24, 2024
View reviewed changes
serhiy-storchaka
serhiy-storchaka reviewed Jan 25, 2024
View reviewed changes
serhiy-storchaka
serhiy-storchaka approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit f7c05d7 into python:main Jan 28, 2024
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@furkanonder @durban @aisk
pythongh-55664: Add warning when creating a type using a namespace di…
939484a 
…ctionary with non-string keys. (pythonGH-105338)

Co-authored-by: Daniel Urban <durban@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@furkanonder @serhiy-storchaka @bedevere-bot