Skip to content

gh-105673: Fix uninitialized warning in sysmodule.c #105674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2023
Merged

gh-105673: Fix uninitialized warning in sysmodule.c #105674

merged 1 commit into from
Jun 12, 2023

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Jun 12, 2023 •
edited by bedevere-bot
Loading

@sobolevn sobolevn requested a review from erlend-aasland June 12, 2023 08:20
@bedevere-bot bedevere-bot mentioned this pull request Jun 12, 2023
Closed
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 12, 2023
@erlend-aasland erlend-aasland changed the title gh-105673: Fix ‘value’ may be used uninitialized in this function warning in sysmodule.c gh-105673: Fix uninitialized warning in sysmodule.c Jun 12, 2023
@erlend-aasland erlend-aasland enabled auto-merge (squash) June 12, 2023 08:24
@erlend-aasland erlend-aasland merged commit a8d69fe into python:main Jun 12, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jun 12, 2023

Thanks @sobolevn for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 12, 2023
@sobolevn @miss-islington
pythongh-105673: Fix uninitialized warning in sysmodule.c (pythonGH-1…
ef32a01 
…05674)

In sys_add_xoption(), 'value' may be uninitialized for some error paths.
(cherry picked from commit a8d69fe)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

bedevere-bot commented Jun 12, 2023

GH-105675 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 12, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 12, 2023
@sobolevn @miss-islington
pythongh-105673: Fix uninitialized warning in sysmodule.c (pythonGH-1…
8cc1851 
…05674)

In sys_add_xoption(), 'value' may be uninitialized for some error paths.
(cherry picked from commit a8d69fe)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

bedevere-bot commented Jun 12, 2023

GH-105676 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 12, 2023
erlend-aasland pushed a commit that referenced this pull request Jun 12, 2023
@miss-islington @sobolevn
[3.11] gh-105673: Fix uninitialized warning in sysmodule.c (GH-105674) (
171aa08 
#105676)

In sys_add_xoption(), 'value' may be uninitialized for some error paths.
(cherry picked from commit a8d69fe)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
erlend-aasland pushed a commit that referenced this pull request Jun 12, 2023
@miss-islington @sobolevn
[3.12] gh-105673: Fix uninitialized warning in sysmodule.c (GH-105674) (
0b305e8 
#105675)

In sys_add_xoption(), 'value' may be uninitialized for some error paths.
(cherry picked from commit a8d69fe)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn @miss-islington @bedevere-bot @erlend-aasland