-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
Docs: Avoid a DeprecationWarning in pyspecific.py when running with Sphinx >=6.1
#105886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please could you add comments similar to hugovk@c4a84f6 so we know when to remove the old bit? And shall we tidy up some older imports that weren't commented, like in hugovk@fb4e1cc? (I forgot to open a PR for these!) |
Oh, yours is better than mine, do you just want to open a PR (or two) with your patch(es)? :) |
|
It's fine, we can do it here, we don't want to run out of PR numbers! 🙃 You could add a |
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
|
Should we backport this? Might make us run out of PR numbers sooner. |
|
Yes, let's backport it. (We've saved one PR number, so can invest in two more.) |
We rather need to waste IDs on an industrial scale to get |
|
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-106010 is a backport of this pull request to the 3.12 branch. |
… Sphinx >=6.1 (pythonGH-105886) (cherry picked from commit a72683b) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
|
GH-106011 is a backport of this pull request to the 3.11 branch. |
… Sphinx >=6.1 (pythonGH-105886) (cherry picked from commit a72683b) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Importing
status_iteratorfromsphinx.utilrather thansphinx.util.displaycauses aDeprecationWarningto be emitted if you're running with Sphinx >= 6.1. We still support the CPython docs being built with older versions of Sphinx that don't yet havesphinx.util.display, however, hence thetry/except ImportErrorblock. You can see this deprecation warning here (though the doctest is also failing on that job, I think for unrelated reasons): https://github.com/python/cpython/actions/runs/5297276975/jobs/9588952949?pr=105882📚 Documentation preview 📚: https://cpython-previews--105886.org.readthedocs.build/