Skip to content

GH-104787: use managed weakrefs in _asyncio#106516

Merged
kumaraditya303 merged 2 commits intopython:mainfrom
kumaraditya303:weakref
Jul 10, 2023
Merged

GH-104787: use managed weakrefs in _asyncio#106516
kumaraditya303 merged 2 commits intopython:mainfrom
kumaraditya303:weakref

Conversation

@kumaraditya303
Copy link
Copy Markdown
Contributor

@kumaraditya303 kumaraditya303 commented Jul 7, 2023

@gvanrossum
Copy link
Copy Markdown
Member

I'm not sure who is an expert in these APIs. Maybe @markshannon can review?

@kumaraditya303
Copy link
Copy Markdown
Contributor Author

I'm not sure who is an expert in these APIs.

Not much to review, see

static PyType_Spec HeapCTypeWithManagedWeakref_spec = {
"_testcapi.HeapCTypeWithManagedWeakref",
sizeof(PyObject),
0,
Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE | Py_TPFLAGS_HAVE_GC | Py_TPFLAGS_MANAGED_WEAKREF,
HeapCTypeWithManagedWeakref_slots
};
as example of usage

Comment thread Modules/_asynciomodule.c
@kumaraditya303 kumaraditya303 merged commit 8fb6edf into python:main Jul 10, 2023
@kumaraditya303 kumaraditya303 deleted the weakref branch July 10, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance or resource usage skip news topic-asyncio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants