gh-107980: fix doc role for asyncio.timeouts #108126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tinche
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
gvanrossum
reviewed
Aug 19, 2023
Tinche
force-pushed
the
tin/timeout-doc-fix
branch
from
400bf99 to
a9e3e66
Compare
kumaraditya303
approved these changes
Aug 19, 2023
AA-Turner
approved these changes
Aug 19, 2023
AA-Turner
added
needs backport to 3.11
gvanrossum
approved these changes
Aug 19, 2023
Contributor
|
Thanks @Tinche for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-108152 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 19, 2023
(cherry picked from commit a47c13c) Co-authored-by: Tin Tvrtković <tinchester@gmail.com>
|
GH-108153 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 19, 2023
(cherry picked from commit a47c13c) Co-authored-by: Tin Tvrtković <tinchester@gmail.com>
AlexWaygood
pushed a commit
that referenced
this pull request
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick documentation fix: the functions being fixed aren't coroutine functions.
asyncio.{timeout_at,timeout}are incorrectly documented ascoroutine#107980📚 Documentation preview 📚: https://cpython-previews--108126.org.readthedocs.build/