Skip to content

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 19, 2023

@erlend-aasland
Copy link
Contributor Author

The amount of Sphinx warnings in os.rst is huge. I figured it was better to fix them in chunks, starting with the external C functions and macros.

@erlend-aasland
Copy link
Contributor Author

This is a really trivial change; I think it would be ok to merge it as soon as the CI is gree. But, I'll await Adam's review, now that I requested it.

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note:

A

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@erlend-aasland erlend-aasland enabled auto-merge (squash) August 19, 2023 16:52
@erlend-aasland erlend-aasland merged commit c31c61c into python:main Aug 19, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-108143 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 19, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 19, 2023
…onGH-108138)

(cherry picked from commit c31c61c)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-bot
Copy link

GH-108144 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 19, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 19, 2023
…onGH-108138)

(cherry picked from commit c31c61c)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@erlend-aasland erlend-aasland deleted the docs/os.rst-c-stuff branch August 19, 2023 17:06
erlend-aasland added a commit that referenced this pull request Aug 19, 2023
GH-108138) (#108144)

(cherry picked from commit c31c61c)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Yhg1s pushed a commit that referenced this pull request Aug 19, 2023
GH-108138) (#108143)

Docs: Remove links to external C functions and macros in os.rst (GH-108138)
(cherry picked from commit c31c61c)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants