Skip to content

bpo-35393: Fix typo#10876

Closed
AutomCoding wants to merge 1 commit intopython:masterfrom
AutomCoding:patch-1
Closed

bpo-35393: Fix typo#10876
AutomCoding wants to merge 1 commit intopython:masterfrom
AutomCoding:patch-1

Conversation

@AutomCoding
Copy link
Copy Markdown

@AutomCoding AutomCoding commented Dec 3, 2018

There are 256 characters in the range 0–255.

https://bugs.python.org/issue35393

There are 256 characters in the range 0--255.
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Dec 3, 2018
@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@AutomCoding AutomCoding changed the title bpo-NNNN: Fix typo bpo-35393: Fix typo Dec 3, 2018
Comment thread Doc/howto/unicode.rst
company or another and managed to catch on.

255 characters aren't very many. For example, you can't fit both the accented
256 characters aren't very many. For example, you can't fit both the accented
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't leave a comment on line 44, but I think we might want to also change it to say:

hold 256 unique values ranging from 0 to 255.  ASCII codes only went up to 127, so some

I'm concerned that a beginner will see 256 for the first time and wonder where it comes from.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but suggest adding 'one of' to get 'bytes could hold one of 256 unique values ...'.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that that's an improvement.

@csabella
Copy link
Copy Markdown
Contributor

csabella commented May 6, 2019

This doc page was rewritten as part of bpo-20906, so I am closing this issue as out of date.

@csabella csabella closed this May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants