Skip to content

bpo-22831: Use "with" to avoid possible fd leaks in tests (part 2). #10929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 5 commits into from
Mar 5, 2019
Merged

bpo-22831: Use "with" to avoid possible fd leaks in tests (part 2). #10929

serhiy-storchaka merged 5 commits into from
Mar 5, 2019

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Dec 5, 2018 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka requested a review from a team December 5, 2018 16:05
@serhiy-storchaka serhiy-storchaka added the tests Tests in the Lib/test dir label Dec 5, 2018
brettcannon
brettcannon approved these changes Jan 15, 2019
View reviewed changes
Lib/test/test_platform.py

def test_mac_ver(self):
res = platform.mac_ver()

Copy link
Member

@brettcannon brettcannon Jan 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a period.

@serhiy-storchaka serhiy-storchaka merged commit 5b10b98 into python:master Mar 5, 2019
@serhiy-storchaka serhiy-storchaka deleted the fd-leaks-tests2 branch March 5, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @brettcannon @the-knights-who-say-ni @bedevere-bot