Skip to content

Conversation

@encukou
Copy link
Member

@encukou encukou commented Oct 13, 2023

  • Cover the offset fields first
  • Mention the old alternative for MANAGED flags, which is needed to support older Pythons
  • De-emphasize the internal flags: use an inline list.
  • Add a note to PyMemberDef saying what to do with it

(Not to be backported to 3.11, which doesn't have public Py_TPFLAGS_MANAGED_* flags.)


📚 Documentation preview 📚: https://cpython-previews--110813.org.readthedocs.build/

- Cover the offset fields first
- Mention the old alternative for MANAGED flags, which is needed
  to support older Pythons
- De-emphasize the internal flags: use an inline list.
- Add a note to PyMemberDef saying what to do with it
@willingc willingc merged commit 2ab34f0 into python:main Oct 13, 2023
@miss-islington
Copy link
Contributor

Thanks @encukou for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 13, 2023
…ythonGH-110813)

* pythongh-110803: Reorganize docs for what PyType_Slot doesn't cover

- Cover the offset fields first
- Mention the old alternative for MANAGED flags, which is needed
  to support older Pythons
- De-emphasize the internal flags: use an inline list.
- Add a note to PyMemberDef saying what to do with it

* Remove an older draft...
(cherry picked from commit 2ab34f0)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 13, 2023

GH-110823 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 13, 2023
willingc pushed a commit that referenced this pull request Oct 13, 2023
…H-110813) (#110823)

gh-110803: Reorganize docs for what PyType_Slot doesn't cover (GH-110813)

* gh-110803: Reorganize docs for what PyType_Slot doesn't cover

- Cover the offset fields first
- Mention the old alternative for MANAGED flags, which is needed
  to support older Pythons
- De-emphasize the internal flags: use an inline list.
- Add a note to PyMemberDef saying what to do with it

* Remove an older draft...
(cherry picked from commit 2ab34f0)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@encukou encukou deleted the gh-110803 branch October 17, 2023 06:42
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…ythonGH-110813)

* pythongh-110803: Reorganize docs for what PyType_Slot doesn't cover

- Cover the offset fields first
- Mention the old alternative for MANAGED flags, which is needed
  to support older Pythons
- De-emphasize the internal flags: use an inline list.
- Add a note to PyMemberDef saying what to do with it

* Remove an older draft...
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…ythonGH-110813)

* pythongh-110803: Reorganize docs for what PyType_Slot doesn't cover

- Cover the offset fields first
- Mention the old alternative for MANAGED flags, which is needed
  to support older Pythons
- De-emphasize the internal flags: use an inline list.
- Add a note to PyMemberDef saying what to do with it

* Remove an older draft...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants