bpo-35470: Fix a reference counting bug in _PyImport_FindExtensionObjectEx()#11128
Merged
serhiy-storchaka merged 1 commit intopython:masterfrom Jan 10, 2019
Merged
Conversation
zhangyangyu
approved these changes
Dec 12, 2018
ericsnowcurrently
approved these changes
Dec 12, 2018
Member
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
There was a problem hiding this comment.
LGTM
That's what we get for using borrowed references. :/
Member
|
@ZackerySpytz, are you already in Misc/ACKS? If not, be sure to add yourself in this PR. Also, this change (small as it is) should have a NEWS entry. |
serhiy-storchaka
approved these changes
Dec 14, 2018
Member
|
I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches |
Contributor
|
Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-11506 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 10, 2019
…ectEx(). (pythonGH-11128) (cherry picked from commit 89c4f90) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35470