Skip to content

gh-111295: Fix timemodule.c not checking for errors when initializing #111296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 25, 2023
Merged

gh-111295: Fix timemodule.c not checking for errors when initializing #111296

merged 3 commits into from
Oct 25, 2023

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 25, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 25, 2023
Closed
erlend-aasland
erlend-aasland reviewed Oct 25, 2023
View reviewed changes
@erlend-aasland
Style nit
97b9148 
Less lines, less clutter, less indent.
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 25, 2023
@erlend-aasland erlend-aasland enabled auto-merge (squash) October 25, 2023 06:47
@erlend-aasland erlend-aasland merged commit 81b03e7 into python:main Oct 25, 2023
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 25, 2023

Thanks @sobolevn for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Oct 25, 2023

Sorry, @sobolevn and @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 81b03e78101c97c1d3fe5f90908bbf94e83d7df1 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 25, 2023
@sobolevn @miss-islington
pythongh-111295: Fix error checking in time extension module init (py…
d8b1dd7 
…thonGH-111296)

Introduce ADD_INT macro wrapper for PyModule_AddIntConstant()
(cherry picked from commit 81b03e7)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Oct 25, 2023

GH-111300 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 25, 2023
vstinner pushed a commit that referenced this pull request Nov 1, 2023
@miss-islington @sobolevn
[3.12] gh-111295: Fix error checking in time extension module init (G…
a94bdc2 
…H-111296) (#111300)

gh-111295: Fix error checking in time extension module init (GH-111296)

Introduce ADD_INT macro wrapper for PyModule_AddIntConstant()
(cherry picked from commit 81b03e7)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @aisk
pythongh-111295: Fix error checking in time extension module init (py…
2ee9e9d 
…thon#111296)

Introduce ADD_INT macro wrapper for PyModule_AddIntConstant()
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn @Glyphack
pythongh-111295: Fix error checking in time extension module init (py…
a266569 
…thon#111296)

Introduce ADD_INT macro wrapper for PyModule_AddIntConstant()
@ZeroIntensity ZeroIntensity removed the needs backport to 3.11 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees

@erlend-aasland erlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn @erlend-aasland @ZeroIntensity