Skip to content

[3.7] Removed dangling since Python at the end of library/xml.rst. (GH-11201)#11231

Merged
miss-islington merged 2 commits into
python:3.7from
miss-islington:backport-82d7355-3.7
Dec 21, 2018
Merged

[3.7] Removed dangling since Python at the end of library/xml.rst. (GH-11201)#11231
miss-islington merged 2 commits into
python:3.7from
miss-islington:backport-82d7355-3.7

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

(cherry picked from commit 82d7355)

Co-authored-by: Jules Lasne (jlasne) jlasne@student.42.fr

…nGH-11201)

(cherry picked from commit 82d7355)

Co-authored-by: Jules Lasne (jlasne) <jlasne@student.42.fr>
@miss-islington
Copy link
Copy Markdown
Contributor Author

@Seluj78 and @serhiy-storchaka: Status check is done, and it's a success ✅ .

Comment thread Doc/library/xml.rst Outdated
3. :mod:`xmlrpclib` doesn't expand external entities and omits them.
4. Since Python 3.8.0, external general entities are no longer processed by
default since Python.
4. Since Python 3.8, external general entities are no longer processed by
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 3.7.1 instead of 3.8. And docs for 3.8 should refer to 3.7.1 too, because there were no vulnerable releases between 3.7.1 and 3.8.0.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Since Python 3.8, external general entities are no longer processed by
4. Since Python 3.7.1, external general entities are no longer processed by

@miss-islington
Copy link
Copy Markdown
Contributor Author

@Seluj78 and @serhiy-storchaka: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit aa7922a into python:3.7 Dec 21, 2018
@miss-islington miss-islington deleted the backport-82d7355-3.7 branch December 21, 2018 18:22
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Dec 23, 2018
…ythonGH-11201) (pythonGH-11231)

(cherry picked from commit 82d7355)


Co-authored-by: Jules Lasne (jlasne) <jlasne@student.42.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants